From: Ursula Braun <ursula.braun@de.ibm.com>
To: davem@davemloft.net, netdev@vger.kernel.org, linux-s390@vger.kernel.org
Cc: schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com,
Ursula Braun <ursula.braun@de.ibm.com>
Subject: [patch 4/9] [PATCH] claw: invalid return codes from hard_start_xmit
Date: Tue, 24 Mar 2009 13:29:08 +0100 [thread overview]
Message-ID: <20090324124335.784434000@linux.vnet.ibm.com> (raw)
In-Reply-To: 20090324122904.744942000@linux.vnet.ibm.com
[-- Attachment #1: 611-claw-rc-warning.diff --]
[-- Type: text/plain, Size: 824 bytes --]
From: Ursula Braun <ursula.braun@de.ibm.com>
Avoid kernel warnings by using the correct hard_start_xmit return
code NETDEV_TX_BUSY for skb requeuing.
Signed-off-by: Ursula Braun <ursula.braun@de.ibm.com>
---
drivers/s390/net/claw.c | 2 ++
1 file changed, 2 insertions(+)
diff -urpN linux-2.6/drivers/s390/net/claw.c linux-2.6-patched/drivers/s390/net/claw.c
--- linux-2.6/drivers/s390/net/claw.c 2008-12-25 00:26:37.000000000 +0100
+++ linux-2.6-patched/drivers/s390/net/claw.c 2009-03-04 15:58:30.000000000 +0100
@@ -335,6 +335,8 @@ claw_tx(struct sk_buff *skb, struct net_
rc=claw_hw_tx( skb, dev, 1 );
spin_unlock_irqrestore(get_ccwdev_lock(p_ch->cdev), saveflags);
CLAW_DBF_TEXT_(4, trace, "clawtx%d", rc);
+ if (rc)
+ rc = NETDEV_TX_BUSY;
return rc;
} /* end of claw_tx */
next prev parent reply other threads:[~2009-03-24 12:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-24 12:29 [patch 0/9] s390: lcs / ctcm / claw / netiucv patches for 2.6.29 Ursula Braun
2009-03-24 12:29 ` [patch 1/9] [PATCH] Use kthread instead of kernel_thread Ursula Braun
2009-03-24 12:29 ` [patch 2/9] [PATCH] lcs: invalid return codes from hard_start_xmit Ursula Braun
2009-03-24 12:29 ` [patch 3/9] [PATCH] netiucv: invalid return code " Ursula Braun
2009-03-24 12:29 ` Ursula Braun [this message]
2009-03-24 12:29 ` [patch 5/9] [PATCH] ctcm: " Ursula Braun
2009-03-24 12:29 ` [patch 6/9] [PATCH] ctcm: avoid wraparound in length of incoming data Ursula Braun
2009-03-24 12:29 ` [patch 7/9] [PATCH] ctcm: fix minor findings from code analysis tool Ursula Braun
2009-03-24 12:29 ` [patch 8/9] [PATCH] kmsg: convert claw printk messages to kmsg api Ursula Braun
2009-03-24 12:29 ` [patch 9/9] [PATCH] claw: fix minor findings from code analysis tool Ursula Braun
-- strict thread matches above, loose matches on Subject: below --
2009-03-24 13:27 [patch 0/9] [RESEND] s390: lcs / ctcm / claw / netiucv patches for 2.6.29 Ursula Braun
2009-03-24 13:27 ` [patch 4/9] [PATCH] claw: invalid return codes from hard_start_xmit Ursula Braun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090324124335.784434000@linux.vnet.ibm.com \
--to=ursula.braun@de.ibm.com \
--cc=davem@davemloft.net \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).