From: David Miller <davem@davemloft.net>
To: leoli@freescale.com
Cc: shemminger@linux-foundation.org,
bridge@lists.linux-foundation.org, netdev@vger.kernel.org
Subject: Re: [PATCH] net/bridge: use the maximum hard_header_len of ports for bridging device
Date: Wed, 25 Mar 2009 00:06:43 -0700 (PDT) [thread overview]
Message-ID: <20090325.000643.55804624.davem@davemloft.net> (raw)
In-Reply-To: <2a27d3730903250005w2e773b01x1e9ec0606fc0e3d4@mail.gmail.com>
From: Li Yang <leoli@freescale.com>
Date: Wed, 25 Mar 2009 15:05:20 +0800
> On Wed, Mar 25, 2009 at 2:40 PM, David Miller <davem@davemloft.net> wrote:
> > From: Li Yang <leoli@freescale.com>
> > Date: Fri, 20 Mar 2009 17:04:29 +0800
> >
> >> The bridging device used a constant hard_header_len. This will cause
> >> headroom shortage for ports with additional hardware header. The patch
> >> makes bridging device to use the maximum value of all ports.
> >>
> >> Signed-off-by: Li Yang <leoli@freescale.com>
> >
> > Your driver must be able to cope with any amount of
> > available headroom, no matter what hacks we put into
> > the bridging layer.
> >
> > Please fix your driver, I'm not applying this patch.
>
> Ok. But it's not good to reallocate every packet generated locally.
> Why not take this patch too?
Because as Stephen showed it didn't handle all cases.
Look at the patch I posted, that's the way to go.
next prev parent reply other threads:[~2009-03-25 7:06 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-20 9:04 [PATCH] net/bridge: use the maximum hard_header_len of ports for bridging device Li Yang
2009-03-23 7:59 ` Li Yang
2009-03-23 8:02 ` David Miller
2009-03-23 8:15 ` Li Yang
2009-03-23 8:16 ` David Miller
2009-03-23 15:51 ` Stephen Hemminger
2009-03-23 22:20 ` David Miller
2009-03-23 22:45 ` Stephen Hemminger
2009-03-23 22:47 ` David Miller
2009-03-25 8:43 ` Li Yang
2009-03-25 21:35 ` David Miller
2009-03-25 6:40 ` David Miller
2009-03-25 7:05 ` Li Yang
2009-03-25 7:06 ` David Miller [this message]
2009-03-25 8:38 ` Li Yang
2009-03-25 9:15 ` [PATCH] gianfar: reallocate skb when headroom is not enough for fcb Li Yang
2009-03-25 15:53 ` Stephen Hemminger
2009-03-25 21:49 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090325.000643.55804624.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bridge@lists.linux-foundation.org \
--cc=leoli@freescale.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).