* [PATCH] bridge: bad error handling when adding invalid ether address
[not found] <062c01c9adb4$c12a8e80$b100000a@Stig>
@ 2009-03-26 3:57 ` Stephen Hemminger
2009-03-26 4:01 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Hemminger @ 2009-03-26 3:57 UTC (permalink / raw)
To: David Miller; +Cc: 'Stig Thormodsrud', netdev, stable
This fixes an crash when empty bond device is added to a bridge.
If an interface with invalid ethernet address (all zero) is added
to a bridge, then bridge code detects it when setting up the forward
databas entry. But the error unwind is broken, the bridge port object
can get freed twice: once when ref count went to zeo, and once by kfree.
Since object is never really accessible, just free it.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
---
Patch against 2.6.29, but same code has been around for a while
in older releases, so should apply to 2.6.27.y as well.
--- a/net/bridge/br_if.c 2009-03-25 20:29:08.310404430 -0700
+++ b/net/bridge/br_if.c 2009-03-25 20:48:21.353468017 -0700
@@ -426,7 +426,6 @@ err2:
err1:
kobject_del(&p->kobj);
err0:
- kobject_put(&p->kobj);
dev_set_promiscuity(dev, -1);
put_back:
dev_put(dev);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] bridge: bad error handling when adding invalid ether address
2009-03-26 3:57 ` [PATCH] bridge: bad error handling when adding invalid ether address Stephen Hemminger
@ 2009-03-26 4:01 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2009-03-26 4:01 UTC (permalink / raw)
To: shemminger; +Cc: stig, netdev, stable
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Wed, 25 Mar 2009 20:57:00 -0700
> This fixes an crash when empty bond device is added to a bridge.
> If an interface with invalid ethernet address (all zero) is added
> to a bridge, then bridge code detects it when setting up the forward
> databas entry. But the error unwind is broken, the bridge port object
> can get freed twice: once when ref count went to zeo, and once by kfree.
> Since object is never really accessible, just free it.
>
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-03-26 4:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <062c01c9adb4$c12a8e80$b100000a@Stig>
2009-03-26 3:57 ` [PATCH] bridge: bad error handling when adding invalid ether address Stephen Hemminger
2009-03-26 4:01 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).