netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jarek Poplawski <jarkao2@gmail.com>
To: Eric Dumazet <dada1@cosmosbay.com>
Cc: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [RFC] net: release dst entry in dev_queue_xmit()
Date: Wed, 25 Mar 2009 22:12:02 +0100	[thread overview]
Message-ID: <20090325211202.GC2928@ami.dom.local> (raw)
In-Reply-To: <49CA93F5.0@cosmosbay.com>

On Wed, Mar 25, 2009 at 09:28:37PM +0100, Eric Dumazet wrote:
> Jarek Poplawski a écrit :
> 
> > I guess you've considered the loopback too...
> > 
> 
> I had for the first patch (carefuly avoiding loopback being not responsive) :
> I was releasing dst only if enqueue() was called.
> 
> You are right, loopback doesnt work anymore with last patch,
> and I have no idea why...
> 
> Do you know why ?

Hmm.. isn't this test for dst == NULL in ip_rcv_finish expected to be
negative for loopback source?

Jarek P.

  reply	other threads:[~2009-03-25 21:13 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-20 11:40 [RFC] net: release dst entry in dev_queue_xmit() Eric Dumazet
2009-03-20 14:10 ` Neil Horman
2009-03-25  6:43 ` David Miller
2009-03-25  7:13   ` Eric Dumazet
2009-03-25  7:17     ` David Miller
2009-03-25 18:22       ` Jarek Poplawski
2009-03-25 18:41         ` Eric Dumazet
2009-03-25 19:18           ` Jarek Poplawski
2009-03-25 19:40             ` Eric Dumazet
2009-03-25 19:54               ` Jarek Poplawski
2009-03-25 20:28                 ` Eric Dumazet
2009-03-25 21:12                   ` Jarek Poplawski [this message]
2009-03-25 21:20                     ` Patrick McHardy
2009-05-12  8:12 ` [PATCH] net: release dst entry in dev_hard_start_xmit() Eric Dumazet
2009-05-12  8:21   ` Eric Dumazet
2009-05-12 19:26     ` [PATCH, v2] " Eric Dumazet
2009-05-19  5:19       ` David Miller
2009-05-19  5:44         ` Eric Dumazet
2009-05-19 19:44         ` Eric Dumazet
2009-05-19 21:09           ` Jarek Poplawski
2009-05-19 21:21             ` Eric Dumazet
2009-05-19 21:24             ` David Miller
2009-05-12 19:27     ` [PATCH] " Jarek Poplawski
2009-05-12 19:44       ` Eric Dumazet
2009-05-12 20:05         ` Jarek Poplawski
2009-05-12 20:24           ` Jarek Poplawski
2009-05-12 20:52           ` Eric Dumazet
2009-05-12 20:59             ` Jarek Poplawski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090325211202.GC2928@ami.dom.local \
    --to=jarkao2@gmail.com \
    --cc=dada1@cosmosbay.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).