From: David Miller <davem@davemloft.net>
To: rdreier@cisco.com
Cc: torvalds@linux-foundation.org, akpm@linux-foundation.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: RDMA/nes: Fix mis-merge
Date: Fri, 27 Mar 2009 00:29:40 -0700 (PDT) [thread overview]
Message-ID: <20090327.002940.55045245.davem@davemloft.net> (raw)
In-Reply-To: <ada8wmru9hm.fsf@cisco.com>
From: Roland Dreier <rdreier@cisco.com>
Date: Thu, 26 Mar 2009 16:53:25 -0700
> > Btw, as far as I can tell, that function had never been tested with any
> > polling. It had a line like
> >
> > netif_napi_add(netdev, &nesvnic->napi, nes_netdev_poll, 128);
> >
> > but that line was _before_ 'nesvnic' was actually initialized (well, it
> > had been initialized to NULL, so it passed in some NULL-pointer-offset to
> > that function).
>
> Yes, looks like the bug was introduced by d0929553 ("infiniband: convert
> nes driver to net_device_ops"). And unfortunately the nesvnic=NULL
> initialization stopped gcc from warning about used-uninitialized I
> guess. I'll test the final merge out...
Sorry about that, thanks for working this out Roland.
next prev parent reply other threads:[~2009-03-27 7:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-26 9:07 [GIT]: Networking for 2.6.30 David Miller
2009-03-26 9:41 ` Lorenzo Allegrucci
2009-03-26 22:25 ` David Miller
2009-03-26 22:56 ` Linus Torvalds
2009-03-26 23:00 ` David Miller
2009-03-26 23:25 ` RDMA/nes: Fix mis-merge Roland Dreier
2009-03-26 23:31 ` David Miller
2009-03-26 23:38 ` Linus Torvalds
2009-03-26 23:41 ` Linus Torvalds
2009-03-26 23:53 ` Roland Dreier
2009-03-27 7:29 ` David Miller [this message]
2009-03-26 23:48 ` Roland Dreier
2009-03-27 19:16 ` [PATCH] " Roland Dreier
2009-03-27 21:41 ` Linus Torvalds
2009-03-27 22:15 ` Roland Dreier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090327.002940.55045245.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rdreier@cisco.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).