From: Stephen Hemminger <shemminger@linux-foundation.org>
To: David Miller <davem@davemloft.net>, acme@ghostprotocols.net
Cc: netdev@vger.kernel.org
Subject: [patch 04/30] appletalk: convert cops to internal net_device_stats
Date: Thu, 26 Mar 2009 18:11:18 -0700 [thread overview]
Message-ID: <20090327011255.240441939@linux-foundation.org> (raw)
In-Reply-To: 20090327011114.169107105@linux-foundation.org
[-- Attachment #1: cop-stats.patch --]
[-- Type: text/plain, Size: 3758 bytes --]
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
--- a/drivers/net/appletalk/cops.c 2009-03-21 12:36:56.000000000 -0700
+++ b/drivers/net/appletalk/cops.c 2009-03-26 17:04:03.622371138 -0700
@@ -171,7 +171,6 @@ static unsigned int cops_debug = COPS_DE
struct cops_local
{
- struct net_device_stats stats;
int board; /* Holds what board type is. */
int nodeid; /* Set to 1 once have nodeid. */
unsigned char node_acquire; /* Node ID when acquired. */
@@ -197,7 +196,6 @@ static int cops_send_packet (struct sk_
static void set_multicast_list (struct net_device *dev);
static int cops_ioctl (struct net_device *dev, struct ifreq *rq, int cmd);
static int cops_close (struct net_device *dev);
-static struct net_device_stats *cops_get_stats (struct net_device *dev);
static void cleanup_card(struct net_device *dev)
{
@@ -337,7 +335,6 @@ static int __init cops_probe1(struct net
dev->tx_timeout = cops_timeout;
dev->watchdog_timeo = HZ * 2;
- dev->get_stats = cops_get_stats;
dev->open = cops_open;
dev->stop = cops_close;
dev->do_ioctl = cops_ioctl;
@@ -797,7 +794,7 @@ static void cops_rx(struct net_device *d
{
printk(KERN_WARNING "%s: Memory squeeze, dropping packet.\n",
dev->name);
- lp->stats.rx_dropped++;
+ dev->stats.rx_dropped++;
while(pkt_len--) /* Discard packet */
inb(ioaddr);
spin_unlock_irqrestore(&lp->lock, flags);
@@ -819,7 +816,7 @@ static void cops_rx(struct net_device *d
{
printk(KERN_WARNING "%s: Bad packet length of %d bytes.\n",
dev->name, pkt_len);
- lp->stats.tx_errors++;
+ dev->stats.tx_errors++;
dev_kfree_skb_any(skb);
return;
}
@@ -836,7 +833,7 @@ static void cops_rx(struct net_device *d
if(rsp_type != LAP_RESPONSE)
{
printk(KERN_WARNING "%s: Bad packet type %d.\n", dev->name, rsp_type);
- lp->stats.tx_errors++;
+ dev->stats.tx_errors++;
dev_kfree_skb_any(skb);
return;
}
@@ -846,8 +843,8 @@ static void cops_rx(struct net_device *d
skb_reset_transport_header(skb); /* Point to data (Skip header). */
/* Update the counters. */
- lp->stats.rx_packets++;
- lp->stats.rx_bytes += skb->len;
+ dev->stats.rx_packets++;
+ dev->stats.rx_bytes += skb->len;
/* Send packet to a higher place. */
netif_rx(skb);
@@ -858,7 +855,7 @@ static void cops_timeout(struct net_devi
struct cops_local *lp = netdev_priv(dev);
int ioaddr = dev->base_addr;
- lp->stats.tx_errors++;
+ dev->stats.tx_errors++;
if(lp->board==TANGENT)
{
if((inb(ioaddr+TANG_CARD_STATUS)&TANG_TX_READY)==0)
@@ -916,8 +913,8 @@ static int cops_send_packet(struct sk_bu
spin_unlock_irqrestore(&lp->lock, flags); /* Restore interrupts. */
/* Done sending packet, update counters and cleanup. */
- lp->stats.tx_packets++;
- lp->stats.tx_bytes += skb->len;
+ dev->stats.tx_packets++;
+ dev->stats.tx_bytes += skb->len;
dev->trans_start = jiffies;
dev_kfree_skb (skb);
return 0;
@@ -986,15 +983,6 @@ static int cops_close(struct net_device
return 0;
}
-/*
- * Get the current statistics.
- * This may be called with the card open or closed.
- */
-static struct net_device_stats *cops_get_stats(struct net_device *dev)
-{
- struct cops_local *lp = netdev_priv(dev);
- return &lp->stats;
-}
#ifdef MODULE
static struct net_device *cops_dev;
next prev parent reply other threads:[~2009-03-27 1:23 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-27 1:11 [patch 00/30] last of the x86 net_device_ops Stephen Hemminger
2009-03-27 1:11 ` [patch 01/30] 3c503, smc-ultra: netdev_ops bugs Stephen Hemminger
2009-03-27 7:50 ` David Miller
2009-03-27 1:11 ` [patch 02/30] uml: convert network device to internal network device stats Stephen Hemminger
2009-03-27 7:50 ` David Miller
2009-03-27 1:11 ` [patch 03/30] uml: convert network device to netdevice ops Stephen Hemminger
2009-03-27 7:50 ` David Miller
2009-03-27 1:11 ` Stephen Hemminger [this message]
2009-03-27 7:50 ` [patch 04/30] appletalk: convert cops to internal net_device_stats David Miller
2009-03-27 1:11 ` [patch 05/30] To: acme@ghostprotocols.net Subjetct: appltetalk: convert cops device to net_device ops Stephen Hemminger
2009-03-27 7:50 ` [patch 05/30] " David Miller
2009-03-27 1:11 ` [patch 06/30] appletalk: convert LTPC to use internal net_device_stats Stephen Hemminger
2009-03-27 7:50 ` David Miller
2009-03-27 1:11 ` [patch 07/30] appletalk: convert LTPC to net_device_ops Stephen Hemminger
2009-03-27 7:50 ` David Miller
2009-03-27 1:11 ` [patch 08/30] IRDA: convert donauboe " Stephen Hemminger
2009-03-27 7:50 ` David Miller
2009-03-27 1:11 ` [patch 09/30] tokenring: convert drivers " Stephen Hemminger
2009-03-27 7:50 ` David Miller
2009-03-27 1:11 ` [patch 10/30] tokenring: convert smctr " Stephen Hemminger
2009-03-27 7:50 ` David Miller
2009-03-27 1:11 ` [patch 11/30] wan: convert sdla driver " Stephen Hemminger
2009-03-27 7:50 ` David Miller
2009-03-27 1:11 ` [patch 12/30] wireless: convert arlan " Stephen Hemminger
2009-03-27 7:51 ` David Miller
2009-03-27 1:11 ` [patch 13/30] wireless: convert wavelan " Stephen Hemminger
[not found] ` <20090327011255.886835267-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2009-03-27 7:51 ` David Miller
2009-03-27 1:11 ` [patch 14/30] netdev: seeq8005 convert " Stephen Hemminger
2009-03-27 7:51 ` David Miller
2009-03-27 1:11 ` [patch 15/30] netdev: smc9194 " Stephen Hemminger
2009-03-27 7:51 ` David Miller
2009-03-27 1:11 ` [patch 16/30] netdev: smc-ultra32 " Stephen Hemminger
2009-03-27 7:51 ` David Miller
2009-03-27 1:11 ` [patch 17/30] netdev: smc-ultra fix netpoll Stephen Hemminger
2009-03-27 7:51 ` David Miller
2009-03-27 1:11 ` [patch 18/30] lance: convert to net_device_ops Stephen Hemminger
2009-03-27 7:51 ` David Miller
2009-03-27 1:11 ` [patch 19/30] netdev: ibmlana " Stephen Hemminger
2009-03-27 7:51 ` David Miller
2009-03-27 1:11 ` [patch 20/30] netdev: convert eexpress " Stephen Hemminger
2009-03-27 7:51 ` David Miller
2009-03-27 1:11 ` [patch 21/30] netdev: convert eexpro " Stephen Hemminger
2009-03-27 7:51 ` David Miller
2009-03-27 1:11 ` [patch 22/30] netdev: convert at1700 " Stephen Hemminger
2009-03-27 7:51 ` David Miller
2009-03-27 7:52 ` David Miller
2009-03-27 1:11 ` [patch 23/30] netdev: convert depca " Stephen Hemminger
2009-03-27 7:52 ` David Miller
2009-03-27 1:11 ` [patch 24/30] netdev: convert ewrk3 " Stephen Hemminger
2009-03-27 7:52 ` David Miller
2009-03-27 1:11 ` [patch 25/30] netdev: convert ni52 " Stephen Hemminger
2009-03-27 7:52 ` David Miller
2009-03-27 1:11 ` [patch 26/30] netdev: convert ni65 " Stephen Hemminger
2009-03-27 7:52 ` David Miller
2009-03-27 1:11 ` [patch 27/30] netdev: convert ac3200 " Stephen Hemminger
2009-03-27 7:52 ` David Miller
2009-03-27 7:52 ` David Miller
2009-03-27 1:11 ` [patch 28/30] netdev: convert lp486e " Stephen Hemminger
2009-03-27 7:52 ` David Miller
2009-03-27 1:11 ` [patch 29/30] netdev: convert cs89x0 " Stephen Hemminger
2009-03-27 7:52 ` David Miller
2009-03-27 1:11 ` [patch 30/30] netdev: convert eth16i " Stephen Hemminger
2009-03-27 7:52 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090327011255.240441939@linux-foundation.org \
--to=shemminger@linux-foundation.org \
--cc=acme@ghostprotocols.net \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).