From: David Miller <davem@davemloft.net>
To: a.beregalov@gmail.com
Cc: netdev@vger.kernel.org, shemminger@vyatta.com
Subject: Re: [PATCH] ni5010: convert to net_device_ops
Date: Sat, 28 Mar 2009 19:36:04 -0700 (PDT) [thread overview]
Message-ID: <20090328.193604.230866790.davem@davemloft.net> (raw)
In-Reply-To: <20090329022613.GA30897@orion>
From: Alexander Beregalov <a.beregalov@gmail.com>
Date: Sun, 29 Mar 2009 06:26:13 +0400
> @@ -189,6 +189,14 @@ static void __init trigger_irq(int ioaddr)
> outb(MM_EN_XMT|MM_MUX, IE_MMODE); /* Start transmission */
> }
>
> +static const struct net_device_ops ni5010_netdev_ops = {
> + .ndo_open = ni5010_open,
> + .ndo_stop = ni5010_close,
> + .ndo_start_xmit = ni5010_send_packet,
> + .ndo_set_multicast_list = ni5010_set_multicast_list,
> + .ndo_tx_timeout = ni5010_timeout,
> +};
Missing:
.ndo_change_mtu = eth_change_mtu,
.ndo_set_mac_address = eth_mac_addr,
.ndo_validate_addr = eth_validate_addr,
as would have been initialized to dev->foo by alloc_etherdev().
next prev parent reply other threads:[~2009-03-29 2:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-29 2:26 [PATCH] ni5010: convert to net_device_ops Alexander Beregalov
2009-03-29 2:36 ` David Miller [this message]
2009-03-29 2:51 ` Alexander Beregalov
2009-03-29 6:37 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090328.193604.230866790.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=a.beregalov@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).