From: David Miller <davem@davemloft.net>
To: grundler@parisc-linux.org
Cc: kyle@mcmartin.ca, netdev@vger.kernel.org, error27@gmail.com
Subject: Re: Null dereference in uli526x_rx_packet()
Date: Sat, 28 Mar 2009 23:59:31 -0700 (PDT) [thread overview]
Message-ID: <20090328.235931.45430524.davem@davemloft.net> (raw)
In-Reply-To: <20090329053513.GD19602@colo.lackof.org>
From: Grant Grundler <grundler@parisc-linux.org>
Date: Sat, 28 Mar 2009 23:35:13 -0600
> On Fri, Mar 27, 2009 at 11:23:32PM -0400, Kyle McMartin wrote:
> > On Fri, Mar 27, 2009 at 10:47:54PM -0400, Kyle McMartin wrote:
> > > > I don't know if the right fix is to return like this patch does or to set
> > > > skb = rxptr->rx_skb_ptr again.
> > > >
> > >
> > > Ick... that's a good catch. I'll have to think about this.
> > >
> >
> > I think this is alright, it at least keeps the original intent of the
> > code. I don't pretend to have figured it out yet though.
> >
> > I'll stare more at this Monday...
> >
> > I guess the real question is does anyone still have one of these
> > cards. I don't think I do, just the proper tulips. :/
>
> Ditto. AFAIK, I only have tulips.
>
> Patch below looks right to me. Clobbering the skb is certainly wrong.
>
> Acked-by: Grant Grundler <grundler@parisc-linux.org>
It looks correct to me, can we get a proper submission with
signoffs etc.?
next prev parent reply other threads:[~2009-03-29 6:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-27 10:31 Null dereference in uli526x_rx_packet() Dan Carpenter
2009-03-28 2:47 ` Kyle McMartin
2009-03-28 3:23 ` Kyle McMartin
2009-03-29 5:35 ` Grant Grundler
2009-03-29 6:59 ` David Miller [this message]
2009-04-13 2:45 ` Grant Grundler
2009-04-13 2:56 ` David Miller
2010-02-07 7:15 ` Grant Grundler
2010-03-27 3:21 ` David Miller
2010-03-27 6:08 ` Grant Grundler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090328.235931.45430524.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=error27@gmail.com \
--cc=grundler@parisc-linux.org \
--cc=kyle@mcmartin.ca \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).