From: Kyle McMartin <kyle@mcmartin.ca>
To: Dan Carpenter <error27@gmail.com>
Cc: grundler@parisc-linux.org, kyle@mcmartin.ca, netdev@vger.kernel.org
Subject: Re: Null dereference in uli526x_rx_packet()
Date: Fri, 27 Mar 2009 22:47:54 -0400 [thread overview]
Message-ID: <20090328024754.GA16554@bombadil.infradead.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0903270801020.5354@usbsys.site>
On Fri, Mar 27, 2009 at 01:31:36PM +0300, Dan Carpenter wrote:
> Smatch (http://repo.or.cz/w/smatch.git/) complains about the error
> handling in uli526x_rx_packet().
>
> I don't know if the right fix is to return like this patch does or to set
> skb = rxptr->rx_skb_ptr again.
>
Ick... that's a good catch. I'll have to think about this.
regards, Kyle
> --- orig/drivers/net/tulip/uli526x.c 2009-03-27 07:52:32.000000000 +0300
> +++ devel/drivers/net/tulip/uli526x.c 2009-03-27 07:57:05.000000000 +0300
> @@ -844,10 +844,13 @@
>
> /* Good packet, send to upper layer */
> /* Shorst packet used new SKB */
> - if ( (rxlen < RX_COPY_SIZE) &&
> - ( (skb = dev_alloc_skb(rxlen + 2) )
> - != NULL) ) {
> - /* size less than COPY_SIZE, allocate a rxlen SKB */
> + /* size less than COPY_SIZE, allocate a rxlen SKB */
> + if (rxlen < RX_COPY_SIZE) {
> + skb = dev_alloc_skb(rxlen + 2);
> + if (!skb)
> + return;
> + }
> + if (rxlen < RX_COPY_SIZE) {
> skb_reserve(skb, 2); /* 16byte align */
> memcpy(skb_put(skb, rxlen),
> skb_tail_pointer(rxptr->rx_skb_ptr),
>
next prev parent reply other threads:[~2009-03-28 2:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-27 10:31 Null dereference in uli526x_rx_packet() Dan Carpenter
2009-03-28 2:47 ` Kyle McMartin [this message]
2009-03-28 3:23 ` Kyle McMartin
2009-03-29 5:35 ` Grant Grundler
2009-03-29 6:59 ` David Miller
2009-04-13 2:45 ` Grant Grundler
2009-04-13 2:56 ` David Miller
2010-02-07 7:15 ` Grant Grundler
2010-03-27 3:21 ` David Miller
2010-03-27 6:08 ` Grant Grundler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090328024754.GA16554@bombadil.infradead.org \
--to=kyle@mcmartin.ca \
--cc=error27@gmail.com \
--cc=grundler@parisc-linux.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).