netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jesper Dangaard Brouer <hawk@comx.dk>
To: "David S. Miller" <davem@davemloft.net>
Cc: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>, netdev@vger.kernel.org
Subject: [PATCH 2/3] Doc: Fix wrong API example usage of call_rcu().
Date: Mon, 30 Mar 2009 11:03:01 +0200	[thread overview]
Message-ID: <20090330090301.19172.42721.stgit@localhost.localdomain> (raw)
In-Reply-To: <20090330085302.19172.22808.stgit@localhost.localdomain>

At some point the API of call_rcu() changed from three parameters
to two parameters, correct the documentation.

One confusing thing in RCU/listRCU.txt, which is NOT fixed in this patch,
is that no reason or explaination is given for using call_rcu() instead of
the normal synchronize_rcu() call.

Reviewed-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>

Signed-off-by: Jesper Dangaard Brouer <hawk@comx.dk>
---

 Documentation/RCU/listRCU.txt |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/Documentation/RCU/listRCU.txt b/Documentation/RCU/listRCU.txt
index 1fd1753..4349c14 100644
--- a/Documentation/RCU/listRCU.txt
+++ b/Documentation/RCU/listRCU.txt
@@ -118,7 +118,7 @@ Following are the RCU equivalents for these two functions:
 		list_for_each_entry(e, list, list) {
 			if (!audit_compare_rule(rule, &e->rule)) {
 				list_del_rcu(&e->list);
-				call_rcu(&e->rcu, audit_free_rule, e);
+				call_rcu(&e->rcu, audit_free_rule);
 				return 0;
 			}
 		}
@@ -206,7 +206,7 @@ RCU ("read-copy update") its name.  The RCU code is as follows:
 				ne->rule.action = newaction;
 				ne->rule.file_count = newfield_count;
 				list_replace_rcu(e, ne);
-				call_rcu(&e->rcu, audit_free_rule, e);
+				call_rcu(&e->rcu, audit_free_rule);
 				return 0;
 			}
 		}
@@ -283,7 +283,7 @@ flag under the spinlock as follows:
 				list_del_rcu(&e->list);
 				e->deleted = 1;
 				spin_unlock(&e->lock);
-				call_rcu(&e->rcu, audit_free_rule, e);
+				call_rcu(&e->rcu, audit_free_rule);
 				return 0;
 			}
 		}


  parent reply	other threads:[~2009-03-30  9:03 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-30  9:02 [PATCH 0/3] Trivial doc fixes for RCU (v3) Jesper Dangaard Brouer
2009-03-30  9:02 ` [PATCH 1/3] Doc: Fix missing whitespaces in RCU documentation Jesper Dangaard Brouer
2009-03-30  9:03 ` Jesper Dangaard Brouer [this message]
2009-03-30  9:03 ` [PATCH 3/3] Doc: Fix spelling in RCU/rculist_nulls.txt Jesper Dangaard Brouer
2009-03-30 16:59   ` Jarek Poplawski
2009-03-30 19:59     ` Jesper Dangaard Brouer
2009-03-30 20:10       ` Eric Dumazet
2009-03-30 20:11       ` [PATCH v2 " Jesper Dangaard Brouer
2009-03-31 10:54         ` Jarek Poplawski
2009-03-31 19:17           ` Jesper Dangaard Brouer
2009-03-31 19:36             ` Jesper Dangaard Brouer
2009-04-01  5:34               ` Jarek Poplawski
2009-04-02  8:28 ` [PATCH 0/3] Trivial doc fixes for RCU (v3) David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090330090301.19172.42721.stgit@localhost.localdomain \
    --to=hawk@comx.dk \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=paulmck@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).