* [PATCH] ETHOC: fix build breakage on s390
@ 2009-03-30 9:30 Heiko Carstens
2009-03-30 11:52 ` Thierry Reding
0 siblings, 1 reply; 3+ messages in thread
From: Heiko Carstens @ 2009-03-30 9:30 UTC (permalink / raw)
To: David S. Miller
Cc: Thierry Reding, Martin Schwidefsky, netdev, linux-kernel,
linux-s390
From: Heiko Carstens <heiko.carstens@de.ibm.com>
Let driver depend on HAS_IOMEM to avoid build breakage on s390:
CC drivers/net/ethoc.o
drivers/net/ethoc.c: In function 'ethoc_read':
drivers/net/ethoc.c:221: error: implicit declaration of function 'ioread32'
drivers/net/ethoc.c: In function 'ethoc_write':
drivers/net/ethoc.c:226: error: implicit declaration of function 'iowrite32'
drivers/net/ethoc.c: In function 'ethoc_rx':
drivers/net/ethoc.c:405: error: implicit declaration of function 'memcpy_fromio'
drivers/net/ethoc.c: In function 'ethoc_start_xmit':
drivers/net/ethoc.c:828: error: implicit declaration of function 'memcpy_toio'
Cc: Thierry Reding <thierry.reding@avionic-design.de>
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
---
drivers/net/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-2.6/drivers/net/Kconfig
===================================================================
--- linux-2.6.orig/drivers/net/Kconfig
+++ linux-2.6/drivers/net/Kconfig
@@ -974,7 +974,7 @@ config ENC28J60_WRITEVERIFY
config ETHOC
tristate "OpenCores 10/100 Mbps Ethernet MAC support"
- depends on NET_ETHERNET
+ depends on NET_ETHERNET && HAS_IOMEM
select MII
select PHYLIB
help
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ETHOC: fix build breakage on s390
2009-03-30 9:30 [PATCH] ETHOC: fix build breakage on s390 Heiko Carstens
@ 2009-03-30 11:52 ` Thierry Reding
2009-03-31 21:41 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Thierry Reding @ 2009-03-30 11:52 UTC (permalink / raw)
To: Heiko Carstens
Cc: David S. Miller, Martin Schwidefsky, netdev, linux-kernel,
linux-s390
* Heiko Carstens wrote:
> From: Heiko Carstens <heiko.carstens@de.ibm.com>
>
> Let driver depend on HAS_IOMEM to avoid build breakage on s390:
>
> CC drivers/net/ethoc.o
> drivers/net/ethoc.c: In function 'ethoc_read':
> drivers/net/ethoc.c:221: error: implicit declaration of function 'ioread32'
> drivers/net/ethoc.c: In function 'ethoc_write':
> drivers/net/ethoc.c:226: error: implicit declaration of function 'iowrite32'
> drivers/net/ethoc.c: In function 'ethoc_rx':
> drivers/net/ethoc.c:405: error: implicit declaration of function 'memcpy_fromio'
> drivers/net/ethoc.c: In function 'ethoc_start_xmit':
> drivers/net/ethoc.c:828: error: implicit declaration of function 'memcpy_toio'
>
> Cc: Thierry Reding <thierry.reding@avionic-design.de>
> Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
> ---
> drivers/net/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux-2.6/drivers/net/Kconfig
> ===================================================================
> --- linux-2.6.orig/drivers/net/Kconfig
> +++ linux-2.6/drivers/net/Kconfig
> @@ -974,7 +974,7 @@ config ENC28J60_WRITEVERIFY
>
> config ETHOC
> tristate "OpenCores 10/100 Mbps Ethernet MAC support"
> - depends on NET_ETHERNET
> + depends on NET_ETHERNET && HAS_IOMEM
> select MII
> select PHYLIB
> help
Acked-by: Thierry Reding <thierry.reding@avionic-design.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ETHOC: fix build breakage on s390
2009-03-30 11:52 ` Thierry Reding
@ 2009-03-31 21:41 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2009-03-31 21:41 UTC (permalink / raw)
To: thierry.reding
Cc: heiko.carstens, schwidefsky, netdev, linux-kernel, linux-s390
From: Thierry Reding <thierry.reding@avionic-design.de>
Date: Mon, 30 Mar 2009 13:52:02 +0200
> * Heiko Carstens wrote:
> > From: Heiko Carstens <heiko.carstens@de.ibm.com>
> >
> > Let driver depend on HAS_IOMEM to avoid build breakage on s390:
> >
> > CC drivers/net/ethoc.o
> > drivers/net/ethoc.c: In function 'ethoc_read':
...
> > Cc: Thierry Reding <thierry.reding@avionic-design.de>
> > Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
...
> Acked-by: Thierry Reding <thierry.reding@avionic-design.de>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-03-31 21:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-03-30 9:30 [PATCH] ETHOC: fix build breakage on s390 Heiko Carstens
2009-03-30 11:52 ` Thierry Reding
2009-03-31 21:41 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).