From: David Miller <davem@davemloft.net>
To: andy.grover@gmail.com
Cc: rdreier@cisco.com, andy.grover@oracle.com,
netdev@vger.kernel.org, rds-devel@oss.oracle.com
Subject: Re: [PATCH 6/9] RDS: Fix ordering in a conditional
Date: Tue, 31 Mar 2009 14:50:13 -0700 (PDT) [thread overview]
Message-ID: <20090331.145013.206671022.davem@davemloft.net> (raw)
In-Reply-To: <c0a09e5c0903302356m688fd370k65151f99f43dfdfc@mail.gmail.com>
From: Andrew Grover <andy.grover@gmail.com>
Date: Mon, 30 Mar 2009 23:56:14 -0700
> On Mon, Mar 30, 2009 at 9:27 PM, Roland Dreier <rdreier@cisco.com> wrote:
> > > - if (0 <= ret && (unsigned) ret < nr_pages) {
> > > + if (ret > 0 && (unsigned) ret < nr_pages) {
> >
> > This is not an equivalent transformation -- the original code is true if
> > ret == 0, while the new code is false.
>
> Ah! Good point.
>
> > Also it seems you don't need the unsigned cast here, since the clause
> > before just checked that ret is positive?
>
> True, but I'd bet the compiler will warn if we remove it. I'll try it
> tomorrow and see.
Andy, also please resubmit only the real honest-to-goodness bug fixes
in this patch series.
I don't want to see cleanups, or optimizations like the transformation
over to using get_user_pages_fast().
You could have sent that kind of stuff to me weeks ago.
Thanks.
next prev parent reply other threads:[~2009-03-31 21:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-30 18:44 [PATCH 0/9] RDS updates Andy Grover
2009-03-30 18:44 ` [PATCH 1/9] RDS: Fix m_rs_lock deadlock Andy Grover
2009-03-30 18:44 ` [PATCH 2/9] RDS/IW+IB: Set recv ring low water mark to 1/2 full Andy Grover
2009-03-30 18:44 ` [PATCH 3/9] RDS: Correct some iw references in rdma_transport.c Andy Grover
2009-03-30 18:44 ` [PATCH 4/9] RDS/IW+IB: Set the RDS_LL_SEND_FULL bit when we're throttled Andy Grover
2009-03-30 18:44 ` [PATCH 5/9] RDS/IW+IB: Allow max credit advertise window Andy Grover
2009-03-30 18:44 ` [PATCH 6/9] RDS: Fix ordering in a conditional Andy Grover
2009-03-31 4:27 ` Roland Dreier
2009-03-31 6:56 ` Andrew Grover
2009-03-31 21:50 ` David Miller [this message]
2009-03-30 18:44 ` [PATCH 7/9] RDS: Establish connection before parsing CMSGs Andy Grover
2009-03-30 18:44 ` [PATCH 8/9] RDS: Rewrite connection cleanup Andy Grover
2009-03-30 18:44 ` [PATCH 9/9] RDS: use get_user_pages_fast() Andy Grover
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090331.145013.206671022.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andy.grover@gmail.com \
--cc=andy.grover@oracle.com \
--cc=netdev@vger.kernel.org \
--cc=rdreier@cisco.com \
--cc=rds-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).