From: David Miller <davem@davemloft.net>
To: oliver@neukum.org
Cc: Larry.Finger@lwfinger.net, jgarzik@pobox.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 1/2 V2] kaweth: Fix locking to be SMP-safe
Date: Tue, 31 Mar 2009 15:04:09 -0700 (PDT) [thread overview]
Message-ID: <20090331.150409.149323548.davem@davemloft.net> (raw)
In-Reply-To: <200903312350.38658.oliver@neukum.org>
From: Oliver Neukum <oliver@neukum.org>
Date: Tue, 31 Mar 2009 23:50:38 +0200
> Am Dienstag 31 März 2009 20:45:49 schrieb Larry Finger:
> > On an SMP system, the following message is printed. The patch below gets
> > fixes the problem.
>
> Are you sure it is never called with disabled interrupts?
Please be specific, what is this "it" you are referring to?
Larry's patch modifies the locking many functions, and you didn't
quote the kernel locking error message if that provides the context of
your comment.
next prev parent reply other threads:[~2009-03-31 22:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-31 18:45 [PATCH 1/2 V2] kaweth: Fix locking to be SMP-safe Larry Finger
2009-03-31 21:50 ` Oliver Neukum
2009-03-31 22:04 ` David Miller [this message]
2009-03-31 23:01 ` Larry Finger
2009-03-31 22:13 ` Oliver Neukum
2009-03-31 22:10 ` David Miller
2009-03-31 23:06 ` Oliver Neukum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090331.150409.149323548.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Larry.Finger@lwfinger.net \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oliver@neukum.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).