netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: bhutchings@solarflare.com
Cc: netdev@vger.kernel.org, linux-net-drivers@solarflare.com
Subject: Re: [PATCH] sfc: Call netif_napi_add() before registering our interrupt handler
Date: Tue, 31 Mar 2009 15:07:29 -0700 (PDT)	[thread overview]
Message-ID: <20090331.150729.74805590.davem@davemloft.net> (raw)
In-Reply-To: <1238526464.3254.7.camel@achroite>

From: Ben Hutchings <bhutchings@solarflare.com>
Date: Tue, 31 Mar 2009 20:07:44 +0100

> If we use a shared legacy IRQ then our interrupt handler may be called
> as soon as it is registered even though IRQs are disabled on the NIC.
> Now that the legacy interrupt handler also checks for event delivery,
> it may decide to schedule polling in this case.  Ensure that the NAPI
> context is valid but disabled at this point.
> 
> Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>

Applied, thanks.

      reply	other threads:[~2009-03-31 22:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-31 19:07 [PATCH] sfc: Call netif_napi_add() before registering our interrupt handler Ben Hutchings
2009-03-31 22:07 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090331.150729.74805590.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=bhutchings@solarflare.com \
    --cc=linux-net-drivers@solarflare.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).