* [PATCH] rds: only for x86 or 64-bit at the moment...
@ 2009-03-31 21:06 Kyle McMartin
2009-03-31 21:15 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: Kyle McMartin @ 2009-03-31 21:06 UTC (permalink / raw)
To: andy.grover; +Cc: rds-devel, netdev
From: Kyle McMartin <kyle@redhat.com>
set_64bit doesn't exist anywhere but x86 right now, so either
BITS_PER_LONG needs to be 64, or we need to be on x86, in order to
build this module.
Signed-off-by: Kyle McMartin <kyle@redhat.com>
---
diff --git a/net/rds/Kconfig b/net/rds/Kconfig
index 796773b..84df275 100644
--- a/net/rds/Kconfig
+++ b/net/rds/Kconfig
@@ -1,7 +1,7 @@
config RDS
tristate "Reliable Datagram Sockets (RDS) (EXPERIMENTAL)"
- depends on INET && INFINIBAND_IPOIB && EXPERIMENTAL
+ depends on INET && INFINIBAND_IPOIB && EXPERIMENTAL && (64BIT || X86)
depends on INFINIBAND && INFINIBAND_ADDR_TRANS
---help---
RDS provides reliable, sequenced delivery of datagrams
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] rds: only for x86 or 64-bit at the moment...
2009-03-31 21:06 [PATCH] rds: only for x86 or 64-bit at the moment Kyle McMartin
@ 2009-03-31 21:15 ` David Miller
2009-03-31 23:58 ` Andy Grover
0 siblings, 1 reply; 4+ messages in thread
From: David Miller @ 2009-03-31 21:15 UTC (permalink / raw)
To: kyle; +Cc: andy.grover, rds-devel, netdev
From: Kyle McMartin <kyle@mcmartin.ca>
Date: Tue, 31 Mar 2009 17:06:09 -0400
> From: Kyle McMartin <kyle@redhat.com>
>
> set_64bit doesn't exist anywhere but x86 right now, so either
> BITS_PER_LONG needs to be 64, or we need to be on x86, in order to
> build this module.
>
> Signed-off-by: Kyle McMartin <kyle@redhat.com>
I would prefer the RDS folks simply fix this properly.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] rds: only for x86 or 64-bit at the moment...
2009-03-31 21:15 ` David Miller
@ 2009-03-31 23:58 ` Andy Grover
2009-03-31 23:59 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: Andy Grover @ 2009-03-31 23:58 UTC (permalink / raw)
To: David Miller; +Cc: kyle, rds-devel, netdev
David Miller wrote:
> From: Kyle McMartin <kyle@mcmartin.ca>
> Date: Tue, 31 Mar 2009 17:06:09 -0400
>
>> From: Kyle McMartin <kyle@redhat.com>
>>
>> set_64bit doesn't exist anywhere but x86 right now, so either
>> BITS_PER_LONG needs to be 64, or we need to be on x86, in order to
>> build this module.
>>
>> Signed-off-by: Kyle McMartin <kyle@redhat.com>
>
> I would prefer the RDS folks simply fix this properly.
Ok... I'll redo the latest rds patchseries with crit fixes only and a
fix for this.
Regards -- Andy
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] rds: only for x86 or 64-bit at the moment...
2009-03-31 23:58 ` Andy Grover
@ 2009-03-31 23:59 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2009-03-31 23:59 UTC (permalink / raw)
To: andy.grover; +Cc: kyle, rds-devel, netdev
From: Andy Grover <andy.grover@oracle.com>
Date: Tue, 31 Mar 2009 16:58:46 -0700
> David Miller wrote:
> > From: Kyle McMartin <kyle@mcmartin.ca>
> > Date: Tue, 31 Mar 2009 17:06:09 -0400
> >
> >> From: Kyle McMartin <kyle@redhat.com>
> >>
> >> set_64bit doesn't exist anywhere but x86 right now, so either
> >> BITS_PER_LONG needs to be 64, or we need to be on x86, in order to
> >> build this module.
> >>
> >> Signed-off-by: Kyle McMartin <kyle@redhat.com>
> >
> > I would prefer the RDS folks simply fix this properly.
>
> Ok... I'll redo the latest rds patchseries with crit fixes only and a
> fix for this.
Thanks a lot Andy.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-03-31 23:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-03-31 21:06 [PATCH] rds: only for x86 or 64-bit at the moment Kyle McMartin
2009-03-31 21:15 ` David Miller
2009-03-31 23:58 ` Andy Grover
2009-03-31 23:59 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).