From: Oliver Neukum <oliver@neukum.org>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: jgarzik@pobox.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 1/2] kaweth: Fix locking to be SMP-safe
Date: Tue, 31 Mar 2009 09:39:08 +0200 [thread overview]
Message-ID: <200903310939.09690.oliver@neukum.org> (raw)
In-Reply-To: <49D0EC24.4080206@lwfinger.net>
Am Montag 30 März 2009 17:58:28 schrieb Larry Finger:
> Oliver Neukum wrote:
> > Thanks for this report and the patch. I think, however that it introduces
> > unneeded locking. It seems to me that we should be fine if we fix
> > kaweth_start_xmit(). That code assumes that it is called with interrupts
> > off and under a spinlock. Is that incorrect?
>
> You are correct in that only the locking in kaweth_start_xmit() needs to be
> changed to lock out the other CPU's. In my testing under extreme conditions
Very good.
> (X server over the network), the interface stalled with no logged messages.
Do you get something with sysrq-t ?
Regards
Oliver
next prev parent reply other threads:[~2009-03-31 7:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-29 23:32 [PATCH 1/2] kaweth: Fix locking to be SMP-safe Larry Finger
2009-03-30 6:28 ` Oliver Neukum
2009-03-30 15:58 ` Larry Finger
2009-03-31 7:39 ` Oliver Neukum [this message]
2009-03-31 14:55 ` Larry Finger
2009-03-31 15:13 ` Oliver Neukum
2009-03-31 15:24 ` Larry Finger
2009-03-31 18:40 ` Larry Finger
2009-03-31 22:00 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200903310939.09690.oliver@neukum.org \
--to=oliver@neukum.org \
--cc=Larry.Finger@lwfinger.net \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).