From: Oliver Neukum <oliver@neukum.org>
To: David Miller <davem@davemloft.net>
Cc: Larry.Finger@lwfinger.net, jgarzik@pobox.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 1/2 V2] kaweth: Fix locking to be SMP-safe
Date: Wed, 1 Apr 2009 01:06:10 +0200 [thread overview]
Message-ID: <200904010106.10974.oliver@neukum.org> (raw)
In-Reply-To: <20090331.151028.42671906.davem@davemloft.net>
Am Mittwoch 01 April 2009 00:10:28 schrieb David Miller:
> > Here you enable interrupts. Are you sure ndo_start_xmit is never
> > called with interrupts disabled?
>
> It must never be invoked that way, this would break so many
> drivers.
>
> On the other hand, all of these driver paths never execute
> in a real hardware interrupt context, the deepest it gets
> into is software interrupts. So spin_*lock*_bh() might be
> more appropriate.
Thanks. The patch is good. I'll check the other USB network
drivers.
Regards
Oliver
prev parent reply other threads:[~2009-03-31 23:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-31 18:45 [PATCH 1/2 V2] kaweth: Fix locking to be SMP-safe Larry Finger
2009-03-31 21:50 ` Oliver Neukum
2009-03-31 22:04 ` David Miller
2009-03-31 23:01 ` Larry Finger
2009-03-31 22:13 ` Oliver Neukum
2009-03-31 22:10 ` David Miller
2009-03-31 23:06 ` Oliver Neukum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200904010106.10974.oliver@neukum.org \
--to=oliver@neukum.org \
--cc=Larry.Finger@lwfinger.net \
--cc=davem@davemloft.net \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).