From: Rusty Russell <rusty@rustcorp.com.au>
To: Eric Dumazet <dada1@cosmosbay.com>
Cc: Ingo Molnar <mingo@elte.hu>,
Jeremy Fitzhardinge <jeremy@goop.org>,
Tejun Heo <htejun@gmail.com>,
linux kernel <linux-kernel@vger.kernel.org>,
Linux Netdev List <netdev@vger.kernel.org>,
Joe Perches <joe@perches.com>
Subject: Re: [RFC] percpu: convert SNMP mibs to new infra
Date: Thu, 2 Apr 2009 15:34:33 +1030 [thread overview]
Message-ID: <200904021534.34084.rusty@rustcorp.com.au> (raw)
In-Reply-To: <49D3B61F.8010507@cosmosbay.com>
On Thursday 02 April 2009 05:14:47 Eric Dumazet wrote:
> Here is a preliminary patch for SNMP mibs that seems to work well on x86_32
>
> [RFC] percpu: convert SNMP mibs to new infra
OK, I have a whole heap of "convert to dynamic per-cpu" patches waiting in
the wings too, once Tejun's conversion is complete.
Also, what is optimal depends on the arch: we had a long discussion on this
(it's what local_t was supposed to do, with cpu_local_inc() etc: see
Subject: local_add_return 2008-12-16 thread).
eg. on S/390, atomic_inc is a win over the two-counter version. On Sparc,
two-counter wins. On x86, inc wins (obviously).
But efforts to create a single primitive have been problematic: maybe
open-coding it like this is the Right Thing.
Cheers,
Rusty.
next prev parent reply other threads:[~2009-04-02 5:04 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-01 8:13 [PATCH] x86: percpu_to_op() misses memory and flags clobbers Eric Dumazet
2009-04-01 9:02 ` Jeremy Fitzhardinge
2009-04-01 10:14 ` Eric Dumazet
2009-04-01 16:12 ` Ingo Molnar
2009-04-01 16:41 ` Jeremy Fitzhardinge
2009-04-01 16:44 ` Ingo Molnar
2009-04-01 17:13 ` Eric Dumazet
2009-04-01 18:07 ` Jeremy Fitzhardinge
2009-04-01 18:47 ` Eric Dumazet
2009-04-02 9:52 ` Herbert Xu
2009-04-02 14:12 ` Jeremy Fitzhardinge
2009-04-01 18:44 ` [RFC] percpu: convert SNMP mibs to new infra Eric Dumazet
2009-04-02 0:13 ` Tejun Heo
2009-04-02 4:05 ` Ingo Molnar
2009-04-02 8:07 ` [PATCH] " Eric Dumazet
2009-04-03 0:39 ` Tejun Heo
2009-04-03 17:10 ` Ingo Molnar
2009-04-02 5:04 ` Rusty Russell [this message]
2009-04-02 5:19 ` [RFC] " Eric Dumazet
2009-04-02 11:46 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200904021534.34084.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=dada1@cosmosbay.com \
--cc=htejun@gmail.com \
--cc=jeremy@goop.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).