From: Ingo Molnar <mingo@elte.hu>
To: Eric Dumazet <dada1@cosmosbay.com>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
netfilter@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Patrick McHardy <kaber@trash.net>,
Rusty Russell <rusty@rustcorp.com.au>,
coreteam@netfilter.org
Subject: Re: [netfilter bug] BUG: using smp_processor_id() in preemptible [00000000] code: ssh/9115, caller is ipt_do_table+0xc8/0x559
Date: Thu, 2 Apr 2009 22:22:46 +0200 [thread overview]
Message-ID: <20090402202246.GA12191@elte.hu> (raw)
In-Reply-To: <49D51D86.9030906@cosmosbay.com>
* Eric Dumazet <dada1@cosmosbay.com> wrote:
> Ingo Molnar a écrit :
> > Not sure whether this bug has been reported before (a quick subject
> > search on netdev and lkml suggests that it's not):
> >
> > i switched over -tip to latest -git an hour ago (it was on a v2.6.29
> > base before that), and one of my testboxes started emitting lots of
> > these warnings:
>
>
> Hi Ingo
>
> David put into its tree fix for that a few hours ago
>
> commit fa9a86ddc8ecd2830a5e773facc250f110300ae7
>
> (netfilter: iptables: lock free counters) forgot to disable BH
> in arpt_do_table(), ipt_do_table() and ip6t_do_table()
>
> Use rcu_read_lock_bh() instead of rcu_read_lock() cures the problem.
>
> Reported-and-bisected-by: Roman Mindalev <r000n@r000n.net>
> Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>
> Acked-by: Patrick McHardy <kaber@trash.net>
> Acked-by: Stephen Hemminger <shemminger@vyatta.com>
> Signed-off-by: David S. Miller <davem@davemloft.net>
>
>
> Should be pushed to Linus in next round
>
> Thank you
>
> http://git2.kernel.org/?p=linux/kernel/git/davem/net-2.6.git;a=commitdiff;h=fa9a86ddc8ecd2830a5e773facc250f110300ae7
Small request: it's useful to plain-text include such commits in
such email replies - if the patch is not too large. http is not very
helpful to reply to specifics and it's not very useful when i want
toapply it either. I now have to go hunting for the latest tree :)
Ingo
next prev parent reply other threads:[~2009-04-02 20:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-02 20:01 [netfilter bug] BUG: using smp_processor_id() in preemptible [00000000] code: ssh/9115, caller is ipt_do_table+0xc8/0x559 Ingo Molnar
2009-04-02 20:12 ` [PATCH] netfilter: iptables: lock free counters, PREEMPT_RCU=y fix Ingo Molnar
2009-04-02 20:38 ` Stephen Hemminger
2009-04-02 20:52 ` Ingo Molnar
2009-04-02 20:18 ` [netfilter bug] BUG: using smp_processor_id() in preemptible [00000000] code: ssh/9115, caller is ipt_do_table+0xc8/0x559 Eric Dumazet
2009-04-02 20:22 ` Ingo Molnar [this message]
2009-04-02 20:32 ` Ingo Molnar
2009-04-02 21:16 ` Ingo Molnar
2009-04-04 17:23 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090402202246.GA12191@elte.hu \
--to=mingo@elte.hu \
--cc=coreteam@netfilter.org \
--cc=dada1@cosmosbay.com \
--cc=davem@davemloft.net \
--cc=kaber@trash.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).