netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: jeffrey.t.kirsher@intel.com
Cc: netdev@vger.kernel.org, gospo@redhat.com,
	jesse.brandeburg@intel.com, daveboutcher@gmail.com
Subject: Re: [PATCH] e1000: fix loss of multicast packets
Date: Sat, 04 Apr 2009 16:37:18 -0700 (PDT)	[thread overview]
Message-ID: <20090404.163718.191996887.davem@davemloft.net> (raw)
In-Reply-To: <20090403020030.25363.85273.stgit@lost.foo-projects.org>

From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Thu, 02 Apr 2009 19:00:32 -0700

> e1000 (and e1000e, igb, ixgbe, ixgb) all do a series of
> operations each time a multicast address is added.  The flow goes
> something like
> 
> 1) stack adds one multicast address
> 2) stack passes whole current list of unicast and multicast
>    addresses to driver
> 3) driver clears entire list in hardware
> 4) driver programs each multicast address using iomem in a loop
> 
> This was causing multicast packets to be lost during the
> reprogramming process.
> 
> reference with test program:
> http://kerneltrap.org/mailarchive/linux-netdev/2009/3/14/5160514/thread
> 
> Thanks to Dave Boutcher for his report and test program.
> 
> This driver fix prepares an array all at once in memory and
> programs it in one shot to the hardware, not requiring an "erase"
> cycle.
> 
> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>

Applied, thanks.

  reply	other threads:[~2009-04-04 23:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-03  2:00 [PATCH] e1000: fix loss of multicast packets Jeff Kirsher
2009-04-04 23:37 ` David Miller [this message]
     [not found] <20090320204415.25109.57486.stgit@lindenhurst-2.jf.intel.com>
2009-03-22 18:05 ` Dave Boutcher
2009-03-23  8:09   ` David Miller
2009-03-24  2:53     ` Jeff Kirsher
2009-03-24 11:26       ` Dave Boutcher
2009-03-24 22:50         ` Jeff Kirsher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090404.163718.191996887.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=daveboutcher@gmail.com \
    --cc=gospo@redhat.com \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=jesse.brandeburg@intel.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).