From: David Miller <davem@davemloft.net>
To: tilman@imap.cc
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, hjlipp@web.de
Subject: Re: [PATCH 2/3] gigaset: in file ops, check for device disconnect before anything else
Date: Mon, 06 Apr 2009 17:43:40 -0700 (PDT) [thread overview]
Message-ID: <20090406.174340.253577345.davem@davemloft.net> (raw)
In-Reply-To: <20090404-patch-02.tilman@imap.cc>
From: Tilman Schmidt <tilman@imap.cc>
Date: Sun, 5 Apr 2009 18:39:33 +0200 (CEST)
> When the device is disconnected, the dev structure goes away, so
> trying to report another error via dev_printk is bound to oops.
> To avoid that, first check whether the device is still connected
> and return quietly if it isn't.
>
> Impact: error handling
>
> Signed-off-by: Tilman Schmidt <tilman@imap.cc>
> Reported-by: Paul Bolle <pebolle@tiscali.nl>
> Tested-by: Paul Bolle <pebolle@tiscali.nl>
Applied.
next prev parent reply other threads:[~2009-04-07 0:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-05 16:39 [PATCH 0/3] gigaset: late patches for 2.6.30 Tilman Schmidt
2009-04-05 16:39 ` [PATCH 2/3] gigaset: in file ops, check for device disconnect before anything else Tilman Schmidt
2009-04-07 0:43 ` David Miller [this message]
2009-04-05 16:39 ` [PATCH 3/3] gigaset: documentation update Tilman Schmidt
2009-04-07 0:43 ` David Miller
2009-04-05 16:39 ` [PATCH 1/3] bas_gigaset: use tasklet_hi_schedule for timing critical tasklets Tilman Schmidt
2009-04-07 0:43 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090406.174340.253577345.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=hjlipp@web.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tilman@imap.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).