* Re: [Regression, in, 2.6.29] forcedeth doesn't work after resume from hibernation (was: Re: Resume after hibernation regression in 2.6.29)
@ 2009-04-04 23:54 David Miller
2009-04-06 14:03 ` Ed Swierk
0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2009-04-04 23:54 UTC (permalink / raw)
To: eswierk; +Cc: netdev
Please send a version of this patch that actually applies to
Linus's tree, the line numbers et al. are a lot different
now.
I'll backport and submit that to -stable.
Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Regression, in, 2.6.29] forcedeth doesn't work after resume from hibernation (was: Re: Resume after hibernation regression in 2.6.29)
2009-04-04 23:54 [Regression, in, 2.6.29] forcedeth doesn't work after resume from hibernation (was: Re: Resume after hibernation regression in 2.6.29) David Miller
@ 2009-04-06 14:03 ` Ed Swierk
2009-04-07 0:49 ` [Regression, in, 2.6.29] forcedeth doesn't work after resume from hibernation David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Ed Swierk @ 2009-04-06 14:03 UTC (permalink / raw)
To: David Miller; +Cc: netdev
On Sat, 2009-04-04 at 16:54 -0700, David Miller wrote:
> Please send a version of this patch that actually applies to
> Linus's tree, the line numbers et al. are a lot different
> now.
>
> I'll backport and submit that to -stable.
>
> Thanks.
Reset phy state on resume, fixing a regression caused by powering down
the phy on hibernate.
Signed-off-by: Ed Swierk <eswierk@aristanetworks.com>
---
diff --git a/drivers/net/forcedeth.c b/drivers/net/forcedeth.c
index a858c6f..663a7b3 100644
--- a/drivers/net/forcedeth.c
+++ b/drivers/net/forcedeth.c
@@ -6117,6 +6117,9 @@ static int nv_resume(struct pci_dev *pdev)
pci_write_config_dword(pdev, NV_MSI_PRIV_OFFSET, NV_MSI_PRIV_VALUE);
+ /* restore phy state, including autoneg */
+ phy_init(dev);
+
netif_device_attach(dev);
if (netif_running(dev)) {
rc = nv_open(dev);
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Regression, in, 2.6.29] forcedeth doesn't work after resume from hibernation
2009-04-06 14:03 ` Ed Swierk
@ 2009-04-07 0:49 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2009-04-07 0:49 UTC (permalink / raw)
To: eswierk; +Cc: netdev
From: Ed Swierk <eswierk@aristanetworks.com>
Date: Mon, 06 Apr 2009 07:03:32 -0700
> Reset phy state on resume, fixing a regression caused by powering down
> the phy on hibernate.
>
> Signed-off-by: Ed Swierk <eswierk@aristanetworks.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-04-07 0:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-04-04 23:54 [Regression, in, 2.6.29] forcedeth doesn't work after resume from hibernation (was: Re: Resume after hibernation regression in 2.6.29) David Miller
2009-04-06 14:03 ` Ed Swierk
2009-04-07 0:49 ` [Regression, in, 2.6.29] forcedeth doesn't work after resume from hibernation David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).