From: Michael Buesch <mb@bu3sch.de>
To: "Gary Zambrano" <zambrano@broadcom.com>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
David Miller <davem@davemloft.net>,
netdev@vger.kernel.org
Subject: Re: [Bugme-new] [Bug 12969] New: WARNING: at lib/dma-debug.c:539 check_sync+0xe9/0x341() (Not tainted)
Date: Mon, 6 Apr 2009 21:52:27 +0200 [thread overview]
Message-ID: <200904062152.28233.mb@bu3sch.de> (raw)
In-Reply-To: <66E4AD309580E34AA457975F33D2A7473FBC6A3626@IRVEXCHCCR01.corp.ad.broadcom.com>
Subject: [PATCH] b44: Use kernel DMA addresses for the kernel DMA API
We must not use the device DMA addresses for the kernel DMA API, because
device DMA addresses have an additional offset added for the SSB translation.
Use the original dma_addr_t for the sync operation.
Cc: stable@kernel.org
Signed-off-by: Michael Buesch <mb@bu3sch.de>
---
I could reproduce the bug on my b44 card and this patch fixes it.
Please apply the patch and close the bug. Thanks.
Index: linux-2.6/drivers/net/b44.c
===================================================================
--- linux-2.6.orig/drivers/net/b44.c 2009-04-06 21:47:55.000000000 +0200
+++ linux-2.6/drivers/net/b44.c 2009-04-06 21:50:18.000000000 +0200
@@ -750,7 +750,7 @@
dest_idx * sizeof(*dest_desc),
DMA_BIDIRECTIONAL);
- ssb_dma_sync_single_for_device(bp->sdev, le32_to_cpu(src_desc->addr),
+ ssb_dma_sync_single_for_device(bp->sdev, dest_map->mapping,
RX_PKT_BUF_SZ,
DMA_FROM_DEVICE);
}
--
Greetings, Michael.
next prev parent reply other threads:[~2009-04-06 19:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bug-12969-10286@http.bugzilla.kernel.org/>
2009-04-01 23:50 ` [Bugme-new] [Bug 12969] New: WARNING: at lib/dma-debug.c:539 check_sync+0xe9/0x341() (Not tainted) Andrew Morton
2009-04-03 2:23 ` Sergio Monteiro Basto
2009-04-03 9:57 ` Joerg Roedel
[not found] ` <66E4AD309580E34AA457975F33D2A7473FBC6A35EE@IRVEXCHCCR01.corp.ad.broadcom.com>
2009-04-03 10:01 ` Michael Buesch
2009-04-07 14:31 ` Sergio Monteiro Basto
[not found] ` <20090402114402.a89b956d.akpm@linux-foundation.org>
[not found] ` <66E4AD309580E34AA457975F33D2A7473FBC6A3626@IRVEXCHCCR01.corp.ad.broadcom.com>
2009-04-06 19:52 ` Michael Buesch [this message]
2009-04-04 23:49 [Bugme-new, Bug, " David Miller
2009-04-05 10:03 ` Michael Buesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200904062152.28233.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=zambrano@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).