* [patch] locking typo in xfrm_state.c
@ 2009-04-08 10:45 Dan Carpenter
2009-04-08 11:15 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2009-04-08 10:45 UTC (permalink / raw)
To: netdev
I'm not sure who to send this patch to.
There is a double lock instead of an unlock.
Found by smatch (http://repo.or.cz/w/smatch.git). Compile tested.
regards,
dan carpenter
Signed-off-by: Dan Carpenter <error27@gmail.com>
--- orig/net/xfrm/xfrm_state.c 2009-04-08 09:19:10.000000000 +0300
+++ devel/net/xfrm/xfrm_state.c 2009-04-08 09:19:18.000000000 +0300
@@ -1615,7 +1615,7 @@
spin_lock_bh(&xfrm_state_lock);
list_del(&walk->all);
- spin_lock_bh(&xfrm_state_lock);
+ spin_unlock_bh(&xfrm_state_lock);
}
EXPORT_SYMBOL(xfrm_state_walk_done);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [patch] locking typo in xfrm_state.c
2009-04-08 10:45 [patch] locking typo in xfrm_state.c Dan Carpenter
@ 2009-04-08 11:15 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2009-04-08 11:15 UTC (permalink / raw)
To: error27; +Cc: netdev
From: Dan Carpenter <error27@gmail.com>
Date: Wed, 8 Apr 2009 13:45:48 +0300 (EAT)
> I'm not sure who to send this patch to.
>
> There is a double lock instead of an unlock.
>
> Found by smatch (http://repo.or.cz/w/smatch.git). Compile tested.
Already fixed in mainline and -stable.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-04-08 11:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-04-08 10:45 [patch] locking typo in xfrm_state.c Dan Carpenter
2009-04-08 11:15 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).