netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH -next] ethoc: fix library build errors
@ 2009-04-08 17:00 Randy Dunlap
  2009-04-08 22:41 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2009-04-08 17:00 UTC (permalink / raw)
  To: netdev; +Cc: Thierry Reding, davem

From: Randy Dunlap <randy.dunlap@oracle.com>

ethoc indirectly uses crc32_le() and bitrev32(), so select
those library functions to be built.

drivers/built-in.o: In function `ethoc_set_multicast_list':
ethoc.c:(.text+0x6226f): undefined reference to `crc32_le'
ethoc.c:(.text+0x62276): undefined reference to `bitrev32'

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
cc: Thierry Reding <thierry.reding@avionic-design.de>
---
 drivers/net/Kconfig |    2 ++
 1 file changed, 2 insertions(+)

--- linux-next-20090408.orig/drivers/net/Kconfig
+++ linux-next-20090408/drivers/net/Kconfig
@@ -977,6 +977,8 @@ config ETHOC
 	depends on NET_ETHERNET && HAS_IOMEM
 	select MII
 	select PHYLIB
+	select CRC32
+	select BITREVERSE
 	help
 	  Say Y here if you want to use the OpenCores 10/100 Mbps Ethernet MAC.
 

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH -next] ethoc: fix library build errors
  2009-04-08 17:00 [PATCH -next] ethoc: fix library build errors Randy Dunlap
@ 2009-04-08 22:41 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2009-04-08 22:41 UTC (permalink / raw)
  To: randy.dunlap; +Cc: netdev, thierry.reding

From: Randy Dunlap <randy.dunlap@oracle.com>
Date: Wed, 8 Apr 2009 10:00:39 -0700

> ethoc indirectly uses crc32_le() and bitrev32(), so select
> those library functions to be built.
> 
> drivers/built-in.o: In function `ethoc_set_multicast_list':
> ethoc.c:(.text+0x6226f): undefined reference to `crc32_le'
> ethoc.c:(.text+0x62276): undefined reference to `bitrev32'
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>


Applied, thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-04-08 22:41 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-04-08 17:00 [PATCH -next] ethoc: fix library build errors Randy Dunlap
2009-04-08 22:41 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).