* [PATCH] mv643xx_eth: don't reset the rx coal timer on interface up
@ 2009-04-08 20:44 Lennert Buytenhek
2009-04-08 22:43 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Lennert Buytenhek @ 2009-04-08 20:44 UTC (permalink / raw)
To: David Miller; +Cc: netdev
Move SDMA configuration from interface up to port probe, to prevent
overwriting the receive coalescing timer value on interface up.
Signed-off-by: Lennert Buytenhek <buytenh@marvell.com>
---
drivers/net/mv643xx_eth.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
(The affected code is new in 2.6.30-rcX, so this doesn't apply to 2.6.29.)
diff --git a/drivers/net/mv643xx_eth.c b/drivers/net/mv643xx_eth.c
index a56d9d2..b3185bf 100644
--- a/drivers/net/mv643xx_eth.c
+++ b/drivers/net/mv643xx_eth.c
@@ -2274,8 +2274,6 @@ static void port_start(struct mv643xx_eth_private *mp)
pscr |= FORCE_LINK_PASS;
wrlp(mp, PORT_SERIAL_CONTROL, pscr);
- wrlp(mp, SDMA_CONFIG, PORT_SDMA_CONFIG_DEFAULT_VALUE);
-
/*
* Configure TX path and queues.
*/
@@ -2957,6 +2955,8 @@ static int mv643xx_eth_probe(struct platform_device *pdev)
netif_carrier_off(dev);
+ wrlp(mp, SDMA_CONFIG, PORT_SDMA_CONFIG_DEFAULT_VALUE);
+
set_rx_coal(mp, 250);
set_tx_coal(mp, 0);
--
1.5.6.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mv643xx_eth: don't reset the rx coal timer on interface up
2009-04-08 20:44 [PATCH] mv643xx_eth: don't reset the rx coal timer on interface up Lennert Buytenhek
@ 2009-04-08 22:43 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2009-04-08 22:43 UTC (permalink / raw)
To: buytenh; +Cc: netdev
From: Lennert Buytenhek <buytenh@wantstofly.org>
Date: Wed, 8 Apr 2009 22:44:14 +0200
> Move SDMA configuration from interface up to port probe, to prevent
> overwriting the receive coalescing timer value on interface up.
>
> Signed-off-by: Lennert Buytenhek <buytenh@marvell.com>
Applied, thanks Lennert.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-04-08 22:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-04-08 20:44 [PATCH] mv643xx_eth: don't reset the rx coal timer on interface up Lennert Buytenhek
2009-04-08 22:43 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).