netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH]drivers/net/eql.c:fix a dev leakage
@ 2009-04-08  3:06 Yang Hongyang
  2009-04-08 22:56 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Yang Hongyang @ 2009-04-08  3:06 UTC (permalink / raw)
  To: netdev, David S. Miller

After dev_get_by_name(),we should follow a dev_put().build test only.

Signed-off-by: Yang Hongyang<yanghy@cn.fujitsu.com>

---
 drivers/net/eql.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/net/eql.c b/drivers/net/eql.c
index 51ead79..5210bb1 100644
--- a/drivers/net/eql.c
+++ b/drivers/net/eql.c
@@ -542,6 +542,8 @@ static int eql_s_slave_cfg(struct net_device *dev, slave_config_t __user *scp)
 	}
 	spin_unlock_bh(&eql->queue.lock);
 
+	dev_put(slave_dev);
+
 	return ret;
 }
 
-- 
1.6.0.3

-- 
Regards
Yang Hongyang

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH]drivers/net/eql.c:fix a dev leakage
  2009-04-08  3:06 [PATCH]drivers/net/eql.c:fix a dev leakage Yang Hongyang
@ 2009-04-08 22:56 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2009-04-08 22:56 UTC (permalink / raw)
  To: yanghy; +Cc: netdev

From: Yang Hongyang <yanghy@cn.fujitsu.com>
Date: Wed, 08 Apr 2009 11:06:27 +0800

> After dev_get_by_name(),we should follow a dev_put().build test only.
> 
> Signed-off-by: Yang Hongyang<yanghy@cn.fujitsu.com>

Applied, thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-04-08 22:56 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-04-08  3:06 [PATCH]drivers/net/eql.c:fix a dev leakage Yang Hongyang
2009-04-08 22:56 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).