From: David Miller <davem@davemloft.net>
To: shemminger@vyatta.com
Cc: mschmidt@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] skge: fix occasional BUG during MTU change
Date: Wed, 08 Apr 2009 16:08:22 -0700 (PDT) [thread overview]
Message-ID: <20090408.160822.121490305.davem@davemloft.net> (raw)
In-Reply-To: <20090408160621.06f4e556@s6510>
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Wed, 8 Apr 2009 16:06:21 -0700
> On Wed, 08 Apr 2009 16:01:52 -0700 (PDT)
> David Miller <davem@davemloft.net> wrote:
>
>> From: Michal Schmidt <mschmidt@redhat.com>
>> Date: Tue, 7 Apr 2009 18:36:23 +0200
>>
>> > The BUG_ON(skge->tx_ring.to_use != skge->tx_ring.to_clean) in skge_up()
>> > was sometimes observed when setting MTU.
>> >
>> > skge_down() disables the TX queue, but then reenables it by mistake via
>> > skge_tx_clean().
>> > Fix it by moving the waking of the queue from skge_tx_clean() to the
>> > other caller. And to make sure start_xmit is not in progress on another
>> > CPU, skge_down() should call netif_tx_disable().
>> >
>> > The bug was reported to me by Jiri Jilek whose Debian system sometimes
>> > failed to boot. He tested the patch and the bug did not happen anymore.
>> >
>> > Signed-off-by: Michal Schmidt <mschmidt@redhat.com>
>>
>> Stephen, an ACK possibly?
>
> I wanted to test on real hardware, and am offsite this week.
Ok, I'll wait for that, thanks!
next prev parent reply other threads:[~2009-04-08 23:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-07 16:36 [PATCH] skge: fix occasional BUG during MTU change Michal Schmidt
2009-04-08 23:01 ` David Miller
2009-04-08 23:06 ` Stephen Hemminger
2009-04-08 23:08 ` David Miller [this message]
2009-04-10 4:59 ` Andrew Morton
2009-04-13 23:23 ` David Miller
2009-04-14 17:55 ` Stephen Hemminger
2009-04-14 22:17 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090408.160822.121490305.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mschmidt@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).