From: David Miller <davem@davemloft.net>
To: shemminger@vyatta.com
Cc: therbert@google.com, netdev@vger.kernel.org
Subject: Re: [PATCH] Software receive packet steering
Date: Wed, 08 Apr 2009 16:15:15 -0700 (PDT) [thread overview]
Message-ID: <20090408.161515.40986410.davem@davemloft.net> (raw)
In-Reply-To: <20090408160948.2257d311@s6510>
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Wed, 8 Apr 2009 16:09:48 -0700
> On Wed, 8 Apr 2009 15:48:12 -0700
> Tom Herbert <therbert@google.com> wrote:
>
>> -extern int netif_receive_skb(struct sk_buff *skb);
>> +extern int __netif_receive_skb(struct sk_buff *skb);
>> +
>> +static inline int netif_receive_skb(struct sk_buff *skb)
>> +{
>> +#ifdef CONFIG_NET_SOFTRPS
>> + return netif_rx(skb);
>> +#else
>> + return __netif_receive_skb(skb);
>> +#endif
>> +}
>
> Ugh, this forces all devices receiving back into a single backlog
> queue.
Yes, it basically turns off NAPI.
This patch seems to be throwing the baby out with the
bath water.
next prev parent reply other threads:[~2009-04-08 23:15 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-08 22:48 [PATCH] Software receive packet steering Tom Herbert
2009-04-08 23:08 ` Stephen Hemminger
2009-04-08 23:09 ` Stephen Hemminger
2009-04-08 23:15 ` David Miller [this message]
2009-04-09 16:43 ` Tom Herbert
2009-04-09 18:23 ` Ben Hutchings
2009-04-09 21:17 ` David Miller
2009-04-09 0:36 ` David Miller
2009-04-09 4:40 ` Tom Herbert
2009-04-09 5:24 ` David Miller
2009-04-20 10:32 ` Andi Kleen
2009-04-20 10:46 ` David Miller
2009-04-21 3:26 ` Tom Herbert
2009-04-21 9:48 ` Eric Dumazet
2009-04-21 15:46 ` Stephen Hemminger
2009-04-21 18:52 ` Tom Herbert
2009-04-22 9:21 ` David Miller
2009-04-22 15:46 ` Tom Herbert
2009-04-22 18:49 ` Rick Jones
2009-04-22 20:44 ` Jesper Dangaard Brouer
2009-04-23 6:58 ` Jens Axboe
2009-04-23 7:25 ` David Miller
2009-04-23 7:29 ` Jens Axboe
2009-04-23 9:12 ` Jens Laas
2009-04-22 14:33 ` Martin Josefsson
2009-04-23 7:34 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090408.161515.40986410.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).