netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
To: jarkao2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Cc: a.beregalov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	kernel-testers-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	e1000-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: 2.6.30-rc1: e1000: list_add corruption
Date: Thu, 09 Apr 2009 00:51:06 -0700 (PDT)	[thread overview]
Message-ID: <20090409.005106.96791990.davem@davemloft.net> (raw)
In-Reply-To: <20090409071242.GA5515-8HppEYmqbBCE+EvaaNYduQ@public.gmane.org>

From: Jarek Poplawski <jarkao2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date: Thu, 9 Apr 2009 07:12:42 +0000

> On 09-04-2009 06:20, David Miller wrote:
>> From: Alexander Beregalov <a.beregalov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>> Date: Thu, 9 Apr 2009 08:16:00 +0400
>> 
>>> The host has two interfaces
>>> eth0 - e1000, eth1 - forcedeth.
>>> Both are not working after that messages.
>> 
>> It looks like the NAPI pending list is being modified in an illegal
>> state by forcedeth, and mid-stream to a list_del() an e1000 interrupt
>> comes in and this tries to schedule the e1000 NAPI context and we get
>> list corruption.
> 
> Good point! Feel free to send a patch. ;-)

A real shame, since I sent that analysis in hoping someone else
would do the rest of the digging and write the fix. :-/

  parent reply	other threads:[~2009-04-09  7:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-09  3:45 2.6.30-rc1: e1000: list_add corruption Alexander Beregalov
     [not found] ` <a4423d670904082045q41274747ha08d28a0645ae378-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-04-09  3:48   ` Alexander Beregalov
     [not found]     ` <a4423d670904082048i26585b9boacf7ae449e004b8c-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-04-09  4:16       ` Alexander Beregalov
2009-04-09  4:20         ` David Miller
     [not found]           ` <20090408.212040.184687004.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2009-04-09  7:12             ` Jarek Poplawski
     [not found]               ` <20090409071242.GA5515-8HppEYmqbBCE+EvaaNYduQ@public.gmane.org>
2009-04-09  7:51                 ` David Miller [this message]
2009-04-09  8:01                   ` Jarek Poplawski
2009-04-09  8:04                     ` David Miller
2009-04-09  8:08 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090409.005106.96791990.davem@davemloft.net \
    --to=davem-ft/pcqaiutieiz0/mpfg9q@public.gmane.org \
    --cc=a.beregalov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=e1000-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=jarkao2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=kernel-testers-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).