From: Andrew Morton <akpm@linux-foundation.org>
To: netdev@vger.kernel.org
Cc: bugme-daemon@bugzilla.kernel.org, Jay Vosburgh <fubar@us.ibm.com>,
bonding-devel@lists.sourceforge.net, adwol@zonk.pl
Subject: Re: [Bugme-new] [Bug 13004] New: [bonding] xmit hash policy doesn't recognize vlan tagged and PPPoE frames
Date: Thu, 9 Apr 2009 14:10:00 -0700 [thread overview]
Message-ID: <20090409141000.d0ae7fcb.akpm@linux-foundation.org> (raw)
In-Reply-To: <bug-13004-10286@http.bugzilla.kernel.org/>
(switched to email. Please respond via emailed reply-to-all, not via the
bugzilla web interface).
On Fri, 3 Apr 2009 16:34:24 GMT
bugzilla-daemon@bugzilla.kernel.org wrote:
> http://bugzilla.kernel.org/show_bug.cgi?id=13004
>
> Summary: [bonding] xmit hash policy doesn't recognize vlan
> tagged and PPPoE frames
> Product: Networking
> Version: 2.5
> Platform: All
> OS/Version: Linux
> Tree: Mainline
> Status: NEW
> Severity: normal
> Priority: P1
> Component: Other
> AssignedTo: acme@ghostprotocols.net
> ReportedBy: adwol@zonk.pl
> Regression: No
>
>
> Hi,
>
> there is a problem with xmit hash policy in bonding driver. It doesn't work
> when using layer 2+3 or 3+4 policy on vlan tagged or PPPoE frames.
> Functions bond_xmit_hash_policy_l23() and bond_xmit_hash_policy_l34()
> check if frame ethertype is ETH_P_IP and unless, it fall back to layer 2
> hashing. It additionally should check, if frame ethertype is ETH_P_8021Q or
> ETH_P_PPP_SES and embedded type is ETH_P_IP and if so, also treat it as
> IP packet.
>
> Appropriate patch in attachment.
>
Jay, there's a patch in there.
Adam, please prefer to submit patches via email as per
Documentation/SubmittingPatches rather than via bugzilla, thanks.
parent reply other threads:[~2009-04-09 21:13 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <bug-13004-10286@http.bugzilla.kernel.org/>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090409141000.d0ae7fcb.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=adwol@zonk.pl \
--cc=bonding-devel@lists.sourceforge.net \
--cc=bugme-daemon@bugzilla.kernel.org \
--cc=fubar@us.ibm.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).