From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [PATCH 2/2] sysctl: lockdep support for sysctl reference counting. Date: Fri, 10 Apr 2009 02:18:54 -0700 Message-ID: <20090410021854.65c6662a.akpm@linux-foundation.org> References: <49B91A7E.76E4.0078.0@novell.com> <1236934491.5188.209.camel@laptop> <49BA33BE.76E4.0078.0@novell.com> <1236937423.22914.3698.camel@twins> <20090313103828.GB31094@elte.hu> <20090320085205.GB16021@elte.hu> <20090320182404.GA31629@elte.hu> <1237575134.4667.5.camel@laptop> <1237577688.4667.68.camel@laptop> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Ingo Molnar , Jan Beulich , tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, linux-kernel@vger.kernel.org, Gautham R Shenoy , Peter Zijlstra , Alexey Dobriyan , To: ebiederm@xmission.com (Eric W. Biederman) Return-path: Received: from smtp1.linux-foundation.org ([140.211.169.13]:43845 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762180AbZDJJ04 (ORCPT ); Fri, 10 Apr 2009 05:26:56 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Sat, 21 Mar 2009 00:42:19 -0700 ebiederm@xmission.com (Eric W. Biederman) wrote: > It is possible for get lock ordering deadlocks between locks > and waiting for the sysctl used count to drop to zero. We have > recently observed one of these in the networking code. > > So teach the sysctl code how to speak lockdep so the kernel > can warn about these kinds of rare issues proactively. `make headers_check': /usr/src/25/usr/include/linux/sysctl.h:31: included file 'linux/lockdep.h' is not exported make[2]: *** [/usr/src/25/usr/include/linux/.check] Error 1 It looks like we'll need version 2 on these patches..