netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, gospo@redhat.com,
	Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>,
	Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Subject: [PATCH 05/10] ixgbe: Don't return error in flow control configuration if FC is off
Date: Fri, 10 Apr 2009 01:27:39 -0700	[thread overview]
Message-ID: <20090410082739.14372.71625.stgit@localhost.localdomain> (raw)
In-Reply-To: <20090410082618.14372.86091.stgit@localhost.localdomain>

From: PJ Waskiewicz <peter.p.waskiewicz.jr@intel.com>

When flow control is disabled, an invalid low/high watermark configuration
should not matter.

Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---

 drivers/net/ixgbe/ixgbe_82598.c  |    8 +++++---
 drivers/net/ixgbe/ixgbe_common.c |    8 +++++---
 2 files changed, 10 insertions(+), 6 deletions(-)

diff --git a/drivers/net/ixgbe/ixgbe_82598.c b/drivers/net/ixgbe/ixgbe_82598.c
index 982783c..6e2a837 100644
--- a/drivers/net/ixgbe/ixgbe_82598.c
+++ b/drivers/net/ixgbe/ixgbe_82598.c
@@ -381,9 +381,11 @@ static s32 ixgbe_setup_fc_82598(struct ixgbe_hw *hw, s32 packetbuf_num)
 	 * because it causes the controller to just blast out fc packets.
 	 */
 	if (!hw->fc.low_water || !hw->fc.high_water || !hw->fc.pause_time) {
-		hw_dbg(hw, "Invalid water mark configuration\n");
-		ret_val = IXGBE_ERR_INVALID_LINK_SETTINGS;
-		goto out;
+		if (hw->fc.requested_mode != ixgbe_fc_none) {
+			hw_dbg(hw, "Invalid water mark configuration\n");
+			ret_val = IXGBE_ERR_INVALID_LINK_SETTINGS;
+			goto out;
+		}
 	}
 
 	/*
diff --git a/drivers/net/ixgbe/ixgbe_common.c b/drivers/net/ixgbe/ixgbe_common.c
index c1b9045..5f2ee34 100644
--- a/drivers/net/ixgbe/ixgbe_common.c
+++ b/drivers/net/ixgbe/ixgbe_common.c
@@ -1907,9 +1907,11 @@ s32 ixgbe_setup_fc_generic(struct ixgbe_hw *hw, s32 packetbuf_num)
 	 * because it causes the controller to just blast out fc packets.
 	 */
 	if (!hw->fc.low_water || !hw->fc.high_water || !hw->fc.pause_time) {
-		hw_dbg(hw, "Invalid water mark configuration\n");
-		ret_val = IXGBE_ERR_INVALID_LINK_SETTINGS;
-		goto out;
+		if (hw->fc.requested_mode != ixgbe_fc_none) {
+			hw_dbg(hw, "Invalid water mark configuration\n");
+			ret_val = IXGBE_ERR_INVALID_LINK_SETTINGS;
+			goto out;
+		}
 	}
 
 	/*


  parent reply	other threads:[~2009-04-10 16:56 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-10  8:26 [PATCH 01/10] ixgbe: Enable another bit for flow control operation Jeff Kirsher
2009-04-10  8:26 ` [PATCH 02/10] ixgbe: fix IXGBE_MTQC values Jeff Kirsher
2009-04-11  9:50   ` David Miller
2009-04-10  8:27 ` [PATCH 03/10] ixgbe: add support for addition VT_CTL defines Jeff Kirsher
2009-04-11  9:50   ` David Miller
2009-04-10  8:27 ` [PATCH 04/10] ixgbe: add define to support 82599 64 IVAR registers Jeff Kirsher
2009-04-11  9:50   ` David Miller
2009-04-10  8:27 ` Jeff Kirsher [this message]
2009-04-11  9:50   ` [PATCH 05/10] ixgbe: Don't return error in flow control configuration if FC is off David Miller
2009-04-10  8:27 ` [PATCH 06/10] ixgbe: Move PHY ops initialization to centralize bus accesses Jeff Kirsher
2009-04-11  9:50   ` David Miller
2009-04-10  8:28 ` [PATCH 07/10] ixgbe: Remove unnecessary PHY reset, properly identify multispeed fiber modules Jeff Kirsher
2009-04-11  9:51   ` David Miller
2009-04-10  8:28 ` [PATCH 08/10] ixgbe: Update the usage of orig_autoc to be more consistent Jeff Kirsher
2009-04-11  9:51   ` David Miller
2009-04-10  8:28 ` [PATCH 09/10] ixgbe: Update get_physical_layer() calls, plus a version bump Jeff Kirsher
2009-04-11  9:51   ` David Miller
2009-04-10  8:29 ` [PATCH 10/10] Be explict with what we are !'ing in ixgbe_sfp_config_module_task() Jeff Kirsher
2009-04-11  9:51   ` David Miller
2009-04-11  9:49 ` [PATCH 01/10] ixgbe: Enable another bit for flow control operation David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090410082739.14372.71625.stgit@localhost.localdomain \
    --to=jeffrey.t.kirsher@intel.com \
    --cc=davem@davemloft.net \
    --cc=gospo@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=peter.p.waskiewicz.jr@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).