From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, gospo@redhat.com,
Tony Breeds <tony@bakeyournoodle.com>,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Subject: [PATCH 10/10] Be explict with what we are !'ing in ixgbe_sfp_config_module_task()
Date: Fri, 10 Apr 2009 01:29:10 -0700 [thread overview]
Message-ID: <20090410082910.14372.22207.stgit@localhost.localdomain> (raw)
In-Reply-To: <20090410082618.14372.86091.stgit@localhost.localdomain>
From: Tony Breeds <tony@bakeyournoodle.com>
GCC warns:
drivers/net/ixgbe/ixgbe_main.c: In function 'ixgbe_sfp_config_module_task':
drivers/net/ixgbe/ixgbe_main.c:3920: warning: suggest parantheses around
operand of '!' or change '&' to '&&' or '!' to '~'
Which I think is right. Bracket to remove ambiguity.
Signed-off-by: Tony Breeds <tony@bakeyournoodle.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
drivers/net/ixgbe/ixgbe_main.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ixgbe/ixgbe_main.c b/drivers/net/ixgbe/ixgbe_main.c
index 2856486..813c5bc 100644
--- a/drivers/net/ixgbe/ixgbe_main.c
+++ b/drivers/net/ixgbe/ixgbe_main.c
@@ -3917,7 +3917,7 @@ static void ixgbe_sfp_config_module_task(struct work_struct *work)
}
hw->mac.ops.setup_sfp(hw);
- if (!adapter->flags & IXGBE_FLAG_IN_SFP_LINK_TASK)
+ if (!(adapter->flags & IXGBE_FLAG_IN_SFP_LINK_TASK))
/* This will also work for DA Twinax connections */
schedule_work(&adapter->multispeed_fiber_task);
adapter->flags &= ~IXGBE_FLAG_IN_SFP_MOD_TASK;
next prev parent reply other threads:[~2009-04-10 16:57 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-10 8:26 [PATCH 01/10] ixgbe: Enable another bit for flow control operation Jeff Kirsher
2009-04-10 8:26 ` [PATCH 02/10] ixgbe: fix IXGBE_MTQC values Jeff Kirsher
2009-04-11 9:50 ` David Miller
2009-04-10 8:27 ` [PATCH 03/10] ixgbe: add support for addition VT_CTL defines Jeff Kirsher
2009-04-11 9:50 ` David Miller
2009-04-10 8:27 ` [PATCH 04/10] ixgbe: add define to support 82599 64 IVAR registers Jeff Kirsher
2009-04-11 9:50 ` David Miller
2009-04-10 8:27 ` [PATCH 05/10] ixgbe: Don't return error in flow control configuration if FC is off Jeff Kirsher
2009-04-11 9:50 ` David Miller
2009-04-10 8:27 ` [PATCH 06/10] ixgbe: Move PHY ops initialization to centralize bus accesses Jeff Kirsher
2009-04-11 9:50 ` David Miller
2009-04-10 8:28 ` [PATCH 07/10] ixgbe: Remove unnecessary PHY reset, properly identify multispeed fiber modules Jeff Kirsher
2009-04-11 9:51 ` David Miller
2009-04-10 8:28 ` [PATCH 08/10] ixgbe: Update the usage of orig_autoc to be more consistent Jeff Kirsher
2009-04-11 9:51 ` David Miller
2009-04-10 8:28 ` [PATCH 09/10] ixgbe: Update get_physical_layer() calls, plus a version bump Jeff Kirsher
2009-04-11 9:51 ` David Miller
2009-04-10 8:29 ` Jeff Kirsher [this message]
2009-04-11 9:51 ` [PATCH 10/10] Be explict with what we are !'ing in ixgbe_sfp_config_module_task() David Miller
2009-04-11 9:49 ` [PATCH 01/10] ixgbe: Enable another bit for flow control operation David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090410082910.14372.22207.stgit@localhost.localdomain \
--to=jeffrey.t.kirsher@intel.com \
--cc=davem@davemloft.net \
--cc=gospo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=tony@bakeyournoodle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).