From: David Miller <davem@davemloft.net>
To: a.beregalov@gmail.com
Cc: jan.ceuleers@computer.org, netdev@vger.kernel.org,
linux-m68k@vger.kernel.org, geert@linux-m68k.org
Subject: Re: [PATCH 1/6] ariadne: convert to net_device_ops
Date: Sat, 11 Apr 2009 02:56:26 -0700 (PDT) [thread overview]
Message-ID: <20090411.025626.125053437.davem@davemloft.net> (raw)
In-Reply-To: <20090410175924.GA20243@orion>
From: Alexander Beregalov <a.beregalov@gmail.com>
Date: Fri, 10 Apr 2009 21:59:24 +0400
> On Fri, Apr 10, 2009 at 06:13:54PM +0200, Jan Ceuleers wrote:
>> Alexander Beregalov wrote:
>> >
>> > Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com>
>> ...
>> > @@ -197,13 +209,8 @@ static int __devinit ariadne_init_one(struct zorro_dev *z,
>> > dev->mem_start = ZTWO_VADDR(mem_start);
>> > dev->mem_end = dev->mem_start+ARIADNE_RAM_SIZE;
>> >
>> > - dev->open = &ariadne_open;
>> > - dev->stop = &ariadne_close;
>> > - dev->hard_start_xmit = &ariadne_start_xmit;
>> > - dev->tx_timeout = &ariadne_tx_timeout;
>> > + dev->netdev_ops = &ariadne_netdev_ops;;
>>
>> We don't really need two semicolons there but I suppose that they won't
>> hurt.
> Thanks!
>
> David, please apply this patch
Just FYI I made sure to integrate this fixed up version.
next prev parent reply other threads:[~2009-04-11 9:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-10 3:24 [PATCH 1/6] ariadne: convert to net_device_ops Alexander Beregalov
2009-04-10 7:03 ` Geert Uytterhoeven
2009-04-10 16:13 ` Jan Ceuleers
2009-04-10 17:59 ` Alexander Beregalov
2009-04-11 9:56 ` David Miller [this message]
2009-04-11 9:44 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090411.025626.125053437.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=a.beregalov@gmail.com \
--cc=geert@linux-m68k.org \
--cc=jan.ceuleers@computer.org \
--cc=linux-m68k@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).