Re: [PATCH] Bonding: fix zero address hole bug in arp_ip_target list

[David Miller <davem@davemloft.net>]

From: Jay Vosburgh <fubar@us.ibm.com>
Date: Fri, 10 Apr 2009 23:51:19 -0700

> Brian Haley <brian.haley@hp.com> wrote:
> 
>>Fix a zero address hole bug in the bonding arp_ip_target list
>>that was causing the bond to ignore ARP replies (bugz 13006).
>>Instead of just setting the array entry to zero, we now
>>copy any additional entries down one slot, putting the
>>zero entry at the end.  With this change we can now have
>>all the loops that walk the array stop when they hit a zero
>>since there will be no addresses after it.
>>
>>Signed-off-by: Brian Haley <brian.haley@hp.com>
> 
> 	This all looks reasonable to me.  This patch appears to be an
> extension of some code (not as a patch) provided in bugzilla 13006 by
> Steve Howard <steve@astutenetworks.com>, so I suspect he should sign off
> on this as well, or at the very least be credited in the log; I'd write
> that as:
> 
> 	Changes are based in part on code fragment provided in kernel
> bugzilla 13006 by Steve Howard <steve@astutenetworks.com>.
> 
> 	This can go to -stable, too.
> 
> 	-J
> 
> Signed-off-by: Jay Vosburgh <fubar@us.ibm.com>

Indeed, please fix up the attribution and I will apply this and
queue up for -stable.