From: David Miller <davem@davemloft.net>
To: akpm@linux-foundation.org
Cc: brian.haley@hp.com, fubar@us.ibm.com, steve@astutenetworks.com,
netdev@vger.kernel.org, bonding-devel@lists.sourceforge.net
Subject: Re: [PATCH v2] Bonding: fix zero address hole bug in arp_ip_target list
Date: Mon, 13 Apr 2009 00:12:01 -0700 (PDT) [thread overview]
Message-ID: <20090413.001201.127700351.davem@davemloft.net> (raw)
In-Reply-To: <20090411115225.8559c713.akpm@linux-foundation.org>
From: Andrew Morton <akpm@linux-foundation.org>
Date: Sat, 11 Apr 2009 11:52:25 -0700
> On Sat, 11 Apr 2009 11:20:02 -0400 Brian Haley <brian.haley@hp.com> wrote:
>
>> Fix a zero address hole bug in the bonding arp_ip_target list
>> that was causing the bond to ignore ARP replies (bugz 13006).
>> Instead of just setting the array entry to zero, we now
>> copy any additional entries down one slot, putting the
>> zero entry at the end. With this change we can now have
>> all the loops that walk the array stop when they hit a zero
>> since there will be no addresses after it.
>>
>> Changes are based in part on code fragment provided in kernel
>> bugzilla 13006 by Steve Howard <steve@astutenetworks.com>
>>
>
> This isn't written down anywhere, but...
>
> If the patch addresses a bugzilla report, please quote the full
> bugzilla URL in the changelog. ie:
> http://bugzilla.kernel.org/show_bug.cgi?id=13006
I've fixed this when checking in Brian's patch, and also
queued it up for -stable.
Thanks!
prev parent reply other threads:[~2009-04-13 7:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-11 15:20 [PATCH v2] Bonding: fix zero address hole bug in arp_ip_target list Brian Haley
2009-04-11 18:52 ` Andrew Morton
2009-04-13 7:12 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090413.001201.127700351.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=bonding-devel@lists.sourceforge.net \
--cc=brian.haley@hp.com \
--cc=fubar@us.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=steve@astutenetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).