From: David Miller <davem@davemloft.net>
To: agust@denx.de
Cc: netdev@vger.kernel.org, afleming@freescale.com
Subject: Re: [PATCH 2/3] phylib: Allow early-out in phy_change
Date: Mon, 13 Apr 2009 14:52:10 -0700 (PDT) [thread overview]
Message-ID: <20090413.145210.265793440.davem@davemloft.net> (raw)
In-Reply-To: <1239105703-26240-2-git-send-email-agust@denx.de>
From: Anatolij Gustschin <agust@denx.de>
Date: Tue, 7 Apr 2009 14:01:42 +0200
> Marvell 88E1121R Dual PHY device can be hardware-configured
> to use shared interrupt pin for both PHY ports. For such
> PHY configurations using shared PHY interrupt phy_interrupt()
> handler will also schedule a work for PHY port which didn't
> cause an interrupt.
>
> This patch adds a possibility for PHY drivers to provide
> did_interrupt() function which reports if the PHY (or a PHY
> port in a multi-PHY device) generated an interrupt. This
> function is called in phy_change() as phy_change() shouldn't
> proceed if it is invoked for a PHY which didn't cause an
> interrupt. So check for interrupt originator in phy_change()
> to allow early-out.
>
> Signed-off-by: Anatolij Gustschin <agust@denx.de>
Applied.
> + * For multy-PHY devices with shared PHY interrupt pin
^^^^^
I fixed that typo when commiting this change.
next prev parent reply other threads:[~2009-04-13 21:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-07 12:01 [PATCH 1/3] phylib: Basic support for the M88E1121R Marvell chip Anatolij Gustschin
2009-04-07 12:01 ` [PATCH 2/3] phylib: Allow early-out in phy_change Anatolij Gustschin
2009-04-07 12:01 ` [PATCH 3/3] phylib: Add interrupt source check function to M88E1121R driver Anatolij Gustschin
2009-04-13 21:51 ` David Miller
2009-04-13 21:52 ` David Miller [this message]
2009-04-13 21:51 ` [PATCH 1/3] phylib: Basic support for the M88E1121R Marvell chip David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090413.145210.265793440.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=afleming@freescale.com \
--cc=agust@denx.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).