From: David Miller <davem@davemloft.net>
To: ilpo.jarvinen@helsinki.fi
Cc: opurdila@ixiacom.com, netdev@vger.kernel.org
Subject: Re: initial congestion window for connections in the listen queue
Date: Mon, 13 Apr 2009 14:58:29 -0700 (PDT) [thread overview]
Message-ID: <20090413.145829.97306950.davem@davemloft.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0904140051100.9234@wrl-59.cs.helsinki.fi>
From: "Ilpo Järvinen" <ilpo.jarvinen@helsinki.fi>
Date: Tue, 14 Apr 2009 00:54:40 +0300 (EEST)
> A long-standing feature in tcp_init_metrics() is such that any of its goto
> reset prevents call to tcp_init_cwnd(). I never remembered to fix that.
Grumble, we definitely need to fix that!
I suspect I added that problem, because tcp_init_metrics() at one
point couldn't cope with a NULL dst. But that is no longer the
case so I'm pretty sure we can unconditionally go:
tp->snd_cwnd = tcp_init_cwnd(tp, dst);
tp->snd_cwnd_stamp = tcp_time_stamp;
in the 'reset' path too, right?
But note thata even if this reset path is taken, we should still have
at least the default ->snd_cwnd value of 2.
next prev parent reply other threads:[~2009-04-13 21:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-13 20:46 initial congestion window for connections in the listen queue Octavian Purdila
2009-04-13 21:26 ` David Miller
2009-04-13 21:54 ` Ilpo Järvinen
2009-04-13 21:58 ` David Miller [this message]
2009-04-14 8:37 ` Ilpo Järvinen
2009-04-14 9:09 ` David Miller
2009-04-14 13:48 ` Octavian Purdila
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090413.145829.97306950.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ilpo.jarvinen@helsinki.fi \
--cc=netdev@vger.kernel.org \
--cc=opurdila@ixiacom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).