From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH 1/1] Tell linkwatch about new interfaces Date: Mon, 13 Apr 2009 16:22:48 -0700 (PDT) Message-ID: <20090413.162248.60285999.davem@davemloft.net> References: <20090404.170539.148727646.davem@davemloft.net> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: amluto@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: jesse.brandeburg@intel.com Return-path: Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:59667 "EHLO sunset.davemloft.net" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1752257AbZDMXW5 (ORCPT ); Mon, 13 Apr 2009 19:22:57 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: From: "Brandeburg, Jesse" Date: Thu, 9 Apr 2009 17:48:04 -0700 (Pacific Daylight Time) > Dave, if we move the netif_carrier_off call to our dev->open like tg3 has, > do you think this is sufficient? Yes. > e1000e: indicate link down at load > > From: Jesse Brandeburg > > same kind of patch as e1000, let driver explicitly push link state > once link comes up. > > Signed-off-by: Jesse Brandeburg I'll wait to get this via Jeff Kirsher. Thanks.