netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: shanwei@cn.fujitsu.com
Cc: yanghy@cn.fujitsu.com, netdev@vger.kernel.org, brian.haley@hp.com
Subject: Re: [PATCH]ipv6:remove useless check
Date: Tue, 14 Apr 2009 02:22:27 -0700 (PDT)	[thread overview]
Message-ID: <20090414.022227.88248944.davem@davemloft.net> (raw)
In-Reply-To: <49E4039C.5080908@cn.fujitsu.com>

From: Shan Wei <shanwei@cn.fujitsu.com>
Date: Tue, 14 Apr 2009 11:31:40 +0800

> Yang Hongyang said:
>> After switch (rthdr->type) {...},the check below is completely useless.Because:
>> if the type is 2,then hdrlen must be 2 and segments_left must be 1,clearly the
>> check is redundant;if the type is not 2,then goto sticky_done,the check is useless
>> too.
>> 
> 
> Add CC  Brian Haley.
> 
> The check is defined only for Type 0 Routing header in section 4.4 of RFC2460: 
> 
>    Hdr Ext Len          8-bit unsigned integer.  Length of the Routing
>                         header in 8-octet units, not including the first
>                         8 octets.  For the Type 0 Routing header, Hdr
>                         Ext Len is equal to two times the number of
>                         addresses in the header.
> 
> Now, Type 0 Routing header has been removed, the check is redundant.
> 
> Reviewed-by: Shan Wei <shanwei@cn.fujitsu.com>
> 
>> Signed-off-by: Yang Hongyang <yanghy@cn.fujitsu.com>

Applied, thanks everyone.

      reply	other threads:[~2009-04-14  9:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-14  1:51 [PATCH]ipv6:remove useless check Yang Hongyang
2009-04-14  3:31 ` Shan Wei
2009-04-14  9:22   ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090414.022227.88248944.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=brian.haley@hp.com \
    --cc=netdev@vger.kernel.org \
    --cc=shanwei@cn.fujitsu.com \
    --cc=yanghy@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).