From: David Miller <davem@davemloft.net>
To: duncan.gibb@siriusit.co.uk
Cc: fubar@us.ibm.com, netdev@vger.kernel.org, jgarzik@pobox.com
Subject: Re: 2.6.29 ALB bonding printk()s every arp
Date: Tue, 14 Apr 2009 16:43:40 -0700 (PDT) [thread overview]
Message-ID: <20090414.164340.06293708.davem@davemloft.net> (raw)
In-Reply-To: <49E518F8.3030109@siriusit.co.uk>
From: Duncan Gibb <duncan.gibb@siriusit.co.uk>
Date: Wed, 15 Apr 2009 00:15:04 +0100
> On 05 Nov 2008 at 01:51, Jay Vosburgh wrote:
>> if (arp->op_code == htons(ARPOP_REPLY)) {
>> /* update rx hash table for this ARP */
>> + printk("rar: update orig %s bond_dev %s\n", orig_dev->name,
>> + bond_dev->name);
>> + bond = bond_dev->priv;
>> rlb_update_entry_from_arp(bond, arp);
>> dprintk("Server received an ARP Reply from client\n");
>> }
>
> Is the printk() in this patch necessary?
>
> We recently put a 2.6.29 kernel on a router with multiple ALB bonds each
> of several e1000 devices. It now generates a log entry every time an
> arp is-at packet arrives at a bonded interface. I'm not sure that's a
> feature...
That's pretty annoying. Jay can we just remove this?
next prev parent reply other threads:[~2009-04-14 23:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-05 1:51 [PATCH net-next-2.6 0/3] bonding: One fix two features Jay Vosburgh
2008-11-05 1:51 ` [PATCH 1/3] bonding: send IPv6 neighbor advertisement on failover Jay Vosburgh
2008-11-05 1:51 ` [PATCH 2/3] bonding: Fix ALB mode to balance traffic on VLANs Jay Vosburgh
2008-11-05 1:51 ` [PATCH 3/3] bonding: alternate agg selection policies for 802.3ad Jay Vosburgh
2009-04-14 23:15 ` 2.6.29 ALB bonding printk()s every arp (was Re: [PATCH 2/3] bonding: Fix ALB mode to balance traffic on VLANs) Duncan Gibb
2009-04-14 23:43 ` David Miller [this message]
2009-04-14 23:51 ` [PATCH] bonding: Remove debug printk Jay Vosburgh
2009-04-14 23:53 ` David Miller
2008-11-06 5:53 ` [PATCH 1/3] bonding: send IPv6 neighbor advertisement on failover Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090414.164340.06293708.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=duncan.gibb@siriusit.co.uk \
--cc=fubar@us.ibm.com \
--cc=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).