From: David Miller <davem@davemloft.net>
To: akpm@linux-foundation.org
Cc: e1000-devel@lists.sourceforge.net, netdev@vger.kernel.org,
roel.kluin@gmail.com, jeffrey.t.kirsher@intel.com
Subject: Re: [PATCH] ixgbe: missing parentheses
Date: Thu, 16 Apr 2009 16:03:38 -0700 (PDT) [thread overview]
Message-ID: <20090416.160338.35558187.davem@davemloft.net> (raw)
In-Reply-To: <20090416141610.ad8b9909.akpm@linux-foundation.org>
From: Andrew Morton <akpm@linux-foundation.org>
Date: Thu, 16 Apr 2009 14:16:10 -0700
>> @@ -3946,7 +3946,7 @@ static void ixgbe_sfp_config_module_task(struct work_struct *work)
>> }
>> hw->mac.ops.setup_sfp(hw);
>>
>> - if (!adapter->flags & IXGBE_FLAG_IN_SFP_LINK_TASK)
>> + if (!(adapter->flags & IXGBE_FLAG_IN_SFP_LINK_TASK))
>> /* This will also work for DA Twinax connections */
>> schedule_work(&adapter->multispeed_fiber_task);
>> adapter->flags &= ~IXGBE_FLAG_IN_SFP_MOD_TASK;
>
> This is fixed in linux-next, but hasn't been pushed to Linus yet.
If I recall correctly, this got submitted to me as a net-next-2.6 only
patch, which obviously isn't correct.
Intel folks, please resubmit this to me for net-2.6 too, thanks.
------------------------------------------------------------------------------
Stay on top of everything new and different, both inside and
around Java (TM) technology - register by April 22, and save
$200 on the JavaOne (SM) conference, June 2-5, 2009, San Francisco.
300 plus technical and hands-on sessions. Register today.
Use priority code J9JMT32. http://p.sf.net/sfu/p
prev parent reply other threads:[~2009-04-16 23:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <49E79D7C.2080200@gmail.com>
2009-04-16 21:16 ` [PATCH] ixgbe: missing parentheses Andrew Morton
2009-04-16 21:25 ` Kirsher, Jeffrey T
2009-04-16 23:04 ` David Miller
2009-04-16 23:03 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090416.160338.35558187.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=e1000-devel@lists.sourceforge.net \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
--cc=roel.kluin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).