* RE: [PATCH] ixgbe: missing parentheses
2009-04-16 21:16 ` [PATCH] ixgbe: missing parentheses Andrew Morton
@ 2009-04-16 21:25 ` Kirsher, Jeffrey T
2009-04-16 23:04 ` David Miller
2009-04-16 23:03 ` David Miller
1 sibling, 1 reply; 4+ messages in thread
From: Kirsher, Jeffrey T @ 2009-04-16 21:25 UTC (permalink / raw)
To: Andrew Morton, Roel Kluin
Cc: e1000-devel@lists.sourceforge.net, netdev@vger.kernel.org
>On Thursday, April 16, 2009 Andrew Morton wrote:
>
>(cc netdev)
>
>On Thu, 16 Apr 2009 23:05:00 +0200
>Roel Kluin <roel.kluin@gmail.com> wrote:
>
>> `!' has a higher precedence than `&'
>>
>> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
>> ---
>> diff --git a/drivers/net/ixgbe/ixgbe_main.c b/drivers/net/ixgbe/ixgbe_main.c
>> index febde45..49a9037 100644
>> --- a/drivers/net/ixgbe/ixgbe_main.c
>> +++ b/drivers/net/ixgbe/ixgbe_main.c
>> @@ -3946,7 +3946,7 @@ static void ixgbe_sfp_config_module_task(struct
>work_struct *work)
>> }
>> hw->mac.ops.setup_sfp(hw);
>>
>> - if (!adapter->flags & IXGBE_FLAG_IN_SFP_LINK_TASK)
>> + if (!(adapter->flags & IXGBE_FLAG_IN_SFP_LINK_TASK))
>> /* This will also work for DA Twinax connections */
>> schedule_work(&adapter->multispeed_fiber_task);
>> adapter->flags &= ~IXGBE_FLAG_IN_SFP_MOD_TASK;
>
>This is fixed in linux-next, but hasn't been pushed to Linus yet.
Yes, Dave has this fix in his net-next-2.6 tree.
Dave - Can we pull this fix into net-2.6?
Cheers,
Jeff
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ixgbe: missing parentheses
2009-04-16 21:16 ` [PATCH] ixgbe: missing parentheses Andrew Morton
2009-04-16 21:25 ` Kirsher, Jeffrey T
@ 2009-04-16 23:03 ` David Miller
1 sibling, 0 replies; 4+ messages in thread
From: David Miller @ 2009-04-16 23:03 UTC (permalink / raw)
To: akpm; +Cc: e1000-devel, netdev, roel.kluin, jeffrey.t.kirsher
From: Andrew Morton <akpm@linux-foundation.org>
Date: Thu, 16 Apr 2009 14:16:10 -0700
>> @@ -3946,7 +3946,7 @@ static void ixgbe_sfp_config_module_task(struct work_struct *work)
>> }
>> hw->mac.ops.setup_sfp(hw);
>>
>> - if (!adapter->flags & IXGBE_FLAG_IN_SFP_LINK_TASK)
>> + if (!(adapter->flags & IXGBE_FLAG_IN_SFP_LINK_TASK))
>> /* This will also work for DA Twinax connections */
>> schedule_work(&adapter->multispeed_fiber_task);
>> adapter->flags &= ~IXGBE_FLAG_IN_SFP_MOD_TASK;
>
> This is fixed in linux-next, but hasn't been pushed to Linus yet.
If I recall correctly, this got submitted to me as a net-next-2.6 only
patch, which obviously isn't correct.
Intel folks, please resubmit this to me for net-2.6 too, thanks.
------------------------------------------------------------------------------
Stay on top of everything new and different, both inside and
around Java (TM) technology - register by April 22, and save
$200 on the JavaOne (SM) conference, June 2-5, 2009, San Francisco.
300 plus technical and hands-on sessions. Register today.
Use priority code J9JMT32. http://p.sf.net/sfu/p
^ permalink raw reply [flat|nested] 4+ messages in thread