Re: [PATCH] macb: Add support of the netpoll API

David Miller
2009-04-17T09:34:06Z

From: Haavard Skinnemoen <haavard.skinnemoen@atmel.com>
Date: Fri, 17 Apr 2009 11:25:53 +0200

> I guess you're right -- we just have to be careful about calling
> printk() from within the driver. But it seems a lot easier to just drop
> the lock before dumping an error message than it is to work around that
> disable_irq() deadlock. And if you're running with verbose debugging
> enabled, you probably shouldn't be using netconsole anyway.

Therefore, do you agree to add Thomas's patch as-is?

If so please provide an Acked-by: