Re: [PATCH] macb: Add support of the netpoll API

Thomas Petazzoni
2009-04-16T09:53:22Z

Le Thu, 16 Apr 2009 11:07:53 +0200,
Haavard Skinnemoen <haavard.skinnemoen@atmel.com> a écrit :

> Hmm...is this safe? What if printk() is called from the macb interrupt
> handler?

I'm not sure, but that strategy is used in most drivers supporting the
netpoll API (3c509.c, 8139cp.c, 8139too.c, b44.c, bfin_mac.c,
bnx2x_main.c, etc.). It also seems to be the way suggested by netpoll
author, http://oss.sgi.com/archives/netdev/2003-10/msg00800.html.

disable_irq() only disables the macb IRQ line. Is that an issue for
printk() execution ?

Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers and embedded Linux development,
consulting, training and support.