From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: Haavard Skinnemoen <haavard.skinnemoen@atmel.com>
Cc: netdev@vger.kernel.org, Michael Opdenacker <michael@free-electrons.com>
Subject: Re: [PATCH] macb: Add support of the netpoll API
Date: Thu, 16 Apr 2009 11:24:35 +0200 [thread overview]
Message-ID: <20090416112435.0b779859@surf> (raw)
In-Reply-To: <20090416110753.5c75b805@hskinnemoen-d830>
Le Thu, 16 Apr 2009 11:07:53 +0200,
Haavard Skinnemoen <haavard.skinnemoen@atmel.com> a écrit :
> Hmm...is this safe? What if printk() is called from the macb interrupt
> handler?
I'm not sure, but that strategy is used in most drivers supporting the
netpoll API (3c509.c, 8139cp.c, 8139too.c, b44.c, bfin_mac.c,
bnx2x_main.c, etc.). It also seems to be the way suggested by netpoll
author, http://oss.sgi.com/archives/netdev/2003-10/msg00800.html.
disable_irq() only disables the macb IRQ line. Is that an issue for
printk() execution ?
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers and embedded Linux development,
consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2009-04-16 9:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-15 13:46 [PATCH] macb: Add support of the netpoll API Thomas Petazzoni
2009-04-16 9:07 ` Haavard Skinnemoen
2009-04-16 9:24 ` Thomas Petazzoni [this message]
2009-04-16 10:31 ` Haavard Skinnemoen
2009-04-17 8:34 ` David Miller
2009-04-17 9:07 ` Haavard Skinnemoen
2009-04-17 9:08 ` David Miller
2009-04-17 9:25 ` Haavard Skinnemoen
2009-04-17 9:33 ` David Miller
2009-04-17 9:50 ` Haavard Skinnemoen
2009-04-17 10:44 ` David Miller
2009-04-17 11:39 ` David Miller
2009-04-20 10:57 ` Haavard Skinnemoen
2009-04-21 8:54 ` David Miller
2009-05-04 11:54 ` [PATCH v3] " Haavard Skinnemoen
2009-05-04 18:08 ` David Miller
2009-04-17 11:41 ` [PATCH] " Haavard Skinnemoen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090416112435.0b779859@surf \
--to=thomas.petazzoni@free-electrons.com \
--cc=haavard.skinnemoen@atmel.com \
--cc=michael@free-electrons.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).