* [net-2.6 PATCH] Be explict with what we are !'ing in ixgbe_sfp_config_module_task()
@ 2009-04-16 23:22 Jeff Kirsher
2009-04-16 23:27 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Jeff Kirsher @ 2009-04-16 23:22 UTC (permalink / raw)
To: davem; +Cc: netdev, gospo, akpm, roel.kluin, Tony Breeds, Jeff Kirsher
From: Tony Breeds <tony@bakeyournoodle.com>
GCC warns:
drivers/net/ixgbe/ixgbe_main.c: In function 'ixgbe_sfp_config_module_task':
drivers/net/ixgbe/ixgbe_main.c:3920: warning: suggest parantheses around
operand of '!' or change '&' to '&&' or '!' to '~'
Which I think is right. Bracket to remove ambiguity.
Signed-off-by: Tony Breeds <tony@bakeyournoodle.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
drivers/net/ixgbe/ixgbe_main.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ixgbe/ixgbe_main.c b/drivers/net/ixgbe/ixgbe_main.c
index febde45..49a9037 100644
--- a/drivers/net/ixgbe/ixgbe_main.c
+++ b/drivers/net/ixgbe/ixgbe_main.c
@@ -3946,7 +3946,7 @@ static void ixgbe_sfp_config_module_task(struct work_struct *work)
}
hw->mac.ops.setup_sfp(hw);
- if (!adapter->flags & IXGBE_FLAG_IN_SFP_LINK_TASK)
+ if (!(adapter->flags & IXGBE_FLAG_IN_SFP_LINK_TASK))
/* This will also work for DA Twinax connections */
schedule_work(&adapter->multispeed_fiber_task);
adapter->flags &= ~IXGBE_FLAG_IN_SFP_MOD_TASK;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [net-2.6 PATCH] Be explict with what we are !'ing in ixgbe_sfp_config_module_task()
2009-04-16 23:22 [net-2.6 PATCH] Be explict with what we are !'ing in ixgbe_sfp_config_module_task() Jeff Kirsher
@ 2009-04-16 23:27 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2009-04-16 23:27 UTC (permalink / raw)
To: jeffrey.t.kirsher; +Cc: netdev, gospo, akpm, roel.kluin, tony
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Thu, 16 Apr 2009 16:22:28 -0700
> GCC warns:
> drivers/net/ixgbe/ixgbe_main.c: In function 'ixgbe_sfp_config_module_task':
> drivers/net/ixgbe/ixgbe_main.c:3920: warning: suggest parantheses around
> operand of '!' or change '&' to '&&' or '!' to '~'
>
> Which I think is right. Bracket to remove ambiguity.
>
> Signed-off-by: Tony Breeds <tony@bakeyournoodle.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-04-16 23:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-04-16 23:22 [net-2.6 PATCH] Be explict with what we are !'ing in ixgbe_sfp_config_module_task() Jeff Kirsher
2009-04-16 23:27 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).