From: David Miller <davem@davemloft.net>
To: bn@niasdigital.com
Cc: hskinnemoen@atmel.com, jgarzik@pobox.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] macb: Kconfig net device compat fixup
Date: Fri, 17 Apr 2009 00:54:51 -0700 (PDT) [thread overview]
Message-ID: <20090417.005451.215477692.davem@davemloft.net> (raw)
In-Reply-To: <1239953045.2837.58.camel@linux-51e8.site>
From: Ben Nizette <bn@niasdigital.com>
Date: Fri, 17 Apr 2009 17:24:05 +1000
> The macb driver hasn't been updated to use net_device_ops and as such
> should select COMPAT_NET_DEV_OPS to avoid build breakage.
>
> Of course really macb should be updated but in the mean time, this at
> least avoid randconfig problems.
>
> Signed-off-by: Ben Nizette <bn@niasdigital.com>
There's about 26 drivers that fall into this category, it's senseless
to pepper the tree over with this kind of annotation that we'll just
release come next release.
We do have enough drivers converted that powerpc, sparc64, and x86
allmodconfig and allyesconfig builds pass even with the compat option
disabled.
And I think the others can just cope with this for now.
Actually, in the net-next-2.6 tree this driver has in fact been
converted :-)
next prev parent reply other threads:[~2009-04-17 7:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-17 7:24 [PATCH] macb: Kconfig net device compat fixup Ben Nizette
2009-04-17 7:46 ` Haavard Skinnemoen
2009-04-17 8:33 ` Haavard Skinnemoen
2009-04-17 7:54 ` David Miller [this message]
2009-04-17 9:11 ` Ben Nizette
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090417.005451.215477692.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bn@niasdigital.com \
--cc=hskinnemoen@atmel.com \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).