From: David Miller <davem@davemloft.net>
To: haavard.skinnemoen@atmel.com
Cc: netdev@vger.kernel.org, nicolas.ferre@atmel.com, erik.waling@konftel.com
Subject: Re: [PATCH 2/2] macb: process the RX ring regardless of interrupt status
Date: Fri, 17 Apr 2009 01:31:07 -0700 (PDT) [thread overview]
Message-ID: <20090417.013107.41038229.davem@davemloft.net> (raw)
In-Reply-To: <1239874331-9431-2-git-send-email-haavard.skinnemoen@atmel.com>
From: Haavard Skinnemoen <haavard.skinnemoen@atmel.com>
Date: Thu, 16 Apr 2009 11:32:11 +0200
> Suppose that we receive lots of frames, start processing them, but
> exhaust our budget so that we return before we had a chance to look
> at all of them.
>
> Then, when the network layer calls us again, we will only continue
> processing the buffers if the REC bit was set in the mean time, which it
> might not be if there was a brief pause in the flow of packets. If this
> happens, we'll simply display a warning and call netif_rx_complete()
> with potentially lots of unprocessed packets in the RX ring...
>
> Fix this by scanning the ring no matter what flags are set in the
> interrupt status register.
>
> Signed-off-by: Erik Waling <erik.waling@konftel.com>
> Signed-off-by: Haavard Skinnemoen <haavard.skinnemoen@atmel.com>
Applied.
next prev parent reply other threads:[~2009-04-17 8:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-16 9:32 [PATCH 1/2] macb: Handle Retry Limit Exceeded errors Haavard Skinnemoen
2009-04-16 9:32 ` [PATCH 2/2] macb: process the RX ring regardless of interrupt status Haavard Skinnemoen
2009-04-16 18:41 ` Gerard Kam
2009-04-17 8:31 ` David Miller [this message]
2009-04-17 8:30 ` [PATCH 1/2] macb: Handle Retry Limit Exceeded errors David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090417.013107.41038229.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=erik.waling@konftel.com \
--cc=haavard.skinnemoen@atmel.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox