* Re: 2.6.30-rc2-git2: Reported regressions from 2.6.29
2009-04-16 21:42 2.6.30-rc2-git2: Reported regressions from 2.6.29 Rafael J. Wysocki
@ 2009-04-17 0:40 ` Linus Torvalds
2009-04-17 1:25 ` Ingo Molnar
2009-04-17 0:41 ` David Miller
` (6 subsequent siblings)
7 siblings, 1 reply; 30+ messages in thread
From: Linus Torvalds @ 2009-04-17 0:40 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Adrian Bunk, Linux SCSI List, Network Development,
Linux Kernel Mailing List, Natalie Protasevich, Linux ACPI,
Andrew Morton, Kernel Testers List, Linux PM List
I think you put this in the wrong regression pile:
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=13112
> Subject : Oops in drain_array
> Submitter : Bart <mmx@riz.pl>
> Date : 2009-04-14 10:21 (3 days old)
> References : http://marc.info/?l=linux-kernel&m=123970493224628&w=4
Hmm. This one seems like it should be in the "since 2.6.28" camp, since if
I read that one right, it happens with 2.6.29.1.
(I mean sure, it might be new since 2.6.29, but it sounds more likely that
it's already in 2.6.29)
Linus
^ permalink raw reply [flat|nested] 30+ messages in thread* Re: 2.6.30-rc2-git2: Reported regressions from 2.6.29
2009-04-17 0:40 ` Linus Torvalds
@ 2009-04-17 1:25 ` Ingo Molnar
[not found] ` <20090417012544.GB16126-X9Un+BFzKDI@public.gmane.org>
0 siblings, 1 reply; 30+ messages in thread
From: Ingo Molnar @ 2009-04-17 1:25 UTC (permalink / raw)
To: Linus Torvalds, Arjan van de Ven
Cc: Rafael J. Wysocki, Linux Kernel Mailing List, Adrian Bunk,
Andrew Morton, Natalie Protasevich, Kernel Testers List,
Network Development, Linux ACPI, Linux PM List, Linux SCSI List
* Linus Torvalds <torvalds@linux-foundation.org> wrote:
>
>
> I think you put this in the wrong regression pile:
>
> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=13112
> > Subject : Oops in drain_array
> > Submitter : Bart <mmx@riz.pl>
> > Date : 2009-04-14 10:21 (3 days old)
> > References : http://marc.info/?l=linux-kernel&m=123970493224628&w=4
>
> Hmm. This one seems like it should be in the "since 2.6.28" camp, since if
> I read that one right, it happens with 2.6.29.1.
>
> (I mean sure, it might be new since 2.6.29, but it sounds more likely that
> it's already in 2.6.29)
I'd suspect it's possibly hardware related:
http://www.kerneloops.org/search.php?search=free_block&btnG=Function+Search
Look at the very similar call signatures - spanning almost all
kernels back to v2.6.16. There's one spike at .27 - perhaps the same
box trying up hard and crashing several times - or a popular distro
kernel?
Or it's a really ancient bug going back to v2.6.16.
Ingo
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: 2.6.30-rc2-git2: Reported regressions from 2.6.29
2009-04-16 21:42 2.6.30-rc2-git2: Reported regressions from 2.6.29 Rafael J. Wysocki
2009-04-17 0:40 ` Linus Torvalds
@ 2009-04-17 0:41 ` David Miller
2009-04-17 21:27 ` Rafael J. Wysocki
2009-04-17 0:46 ` Linus Torvalds
` (5 subsequent siblings)
7 siblings, 1 reply; 30+ messages in thread
From: David Miller @ 2009-04-17 0:41 UTC (permalink / raw)
To: rjw
Cc: linux-kernel, bunk, akpm, torvalds, protasnb, kernel-testers,
netdev, linux-acpi, linux-pm, linux-scsi
From: "Rafael J. Wysocki" <rjw@sisk.pl>
Date: Thu, 16 Apr 2009 23:42:31 +0200 (CEST)
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=13099
> Subject : net, sky2: BUG: unable to handle kernel NULL pointer dereference, pci_vpd_truncate()
> Submitter : Ingo Molnar <mingo@elte.hu>
> Date : 2009-04-06 9:03 (11 days old)
> References : http://marc.info/?l=linux-kernel&m=123900867611321&w=4
> Handled-By : Stephen Hemminger <shemminger@vyatta.com>
Fixed by:
commit d407e32efe060afa2b9a797a91376ebc65b4ce11
Author: Anton Vorontsov <avorontsov@ru.mvista.com>
Date: Wed Apr 1 02:23:41 2009 +0400
PCI: Fix oops in pci_vpd_truncate
pci_vpd_truncate() should check for dev->vpd->attr, otherwise this might
happen:
sky2 driver version 1.22
Unable to handle kernel paging request for data at address 0x0000000c
Faulting instruction address: 0xc01836fc
Oops: Kernel access of bad area, sig: 11 [#1]
[...]
NIP [c01836fc] pci_vpd_truncate+0x38/0x40
LR [c029be18] sky2_probe+0x14c/0x518
Call Trace:
[ef82bde0] [c029bda4] sky2_probe+0xd8/0x518 (unreliable)
[ef82be20] [c018a11c] local_pci_probe+0x24/0x34
[ef82be30] [c018a14c] pci_call_probe+0x20/0x30
[ef82be50] [c018a330] __pci_device_probe+0x64/0x78
[ef82be60] [c018a44c] pci_device_probe+0x30/0x58
[ef82be80] [c01aa270] really_probe+0x78/0x1a0
[ef82bea0] [c01aa460] __driver_attach+0xa4/0xa8
[ef82bec0] [c01a96ac] bus_for_each_dev+0x60/0x9c
[ef82bef0] [c01aa0b4] driver_attach+0x24/0x34
[ef82bf00] [c01a9e08] bus_add_driver+0x12c/0x1cc
[ef82bf20] [c01aa87c] driver_register+0x6c/0x110
[ef82bf30] [c018a770] __pci_register_driver+0x4c/0x9c
[ef82bf50] [c03782c8] sky2_init_module+0x30/0x40
[ef82bf60] [c0001dbc] do_one_initcall+0x34/0x1a0
[ef82bfd0] [c0362240] do_initcalls+0x38/0x58
This happens with CONFIG_SKY2=y, and "ip=on" kernel command line, so
pci_vpd_truncate() is called before late_initcall(pci_sysfs_init),
therefore ->attr isn't yet initialized.
Acked-by: Stephen Hemminger <shemminger@vyatta.com>
Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
^ permalink raw reply [flat|nested] 30+ messages in thread* Re: 2.6.30-rc2-git2: Reported regressions from 2.6.29
2009-04-17 0:41 ` David Miller
@ 2009-04-17 21:27 ` Rafael J. Wysocki
0 siblings, 0 replies; 30+ messages in thread
From: Rafael J. Wysocki @ 2009-04-17 21:27 UTC (permalink / raw)
To: David Miller
Cc: linux-kernel, bunk, akpm, torvalds, protasnb, kernel-testers,
netdev, linux-acpi, linux-pm, linux-scsi
On Friday 17 April 2009, David Miller wrote:
> From: "Rafael J. Wysocki" <rjw@sisk.pl>
> Date: Thu, 16 Apr 2009 23:42:31 +0200 (CEST)
>
> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=13099
> > Subject : net, sky2: BUG: unable to handle kernel NULL pointer dereference, pci_vpd_truncate()
> > Submitter : Ingo Molnar <mingo@elte.hu>
> > Date : 2009-04-06 9:03 (11 days old)
> > References : http://marc.info/?l=linux-kernel&m=123900867611321&w=4
> > Handled-By : Stephen Hemminger <shemminger@vyatta.com>
>
> Fixed by:
>
> commit d407e32efe060afa2b9a797a91376ebc65b4ce11
> Author: Anton Vorontsov <avorontsov@ru.mvista.com>
> Date: Wed Apr 1 02:23:41 2009 +0400
>
> PCI: Fix oops in pci_vpd_truncate
>
> pci_vpd_truncate() should check for dev->vpd->attr, otherwise this might
> happen:
>
> sky2 driver version 1.22
> Unable to handle kernel paging request for data at address 0x0000000c
> Faulting instruction address: 0xc01836fc
> Oops: Kernel access of bad area, sig: 11 [#1]
> [...]
> NIP [c01836fc] pci_vpd_truncate+0x38/0x40
> LR [c029be18] sky2_probe+0x14c/0x518
> Call Trace:
> [ef82bde0] [c029bda4] sky2_probe+0xd8/0x518 (unreliable)
> [ef82be20] [c018a11c] local_pci_probe+0x24/0x34
> [ef82be30] [c018a14c] pci_call_probe+0x20/0x30
> [ef82be50] [c018a330] __pci_device_probe+0x64/0x78
> [ef82be60] [c018a44c] pci_device_probe+0x30/0x58
> [ef82be80] [c01aa270] really_probe+0x78/0x1a0
> [ef82bea0] [c01aa460] __driver_attach+0xa4/0xa8
> [ef82bec0] [c01a96ac] bus_for_each_dev+0x60/0x9c
> [ef82bef0] [c01aa0b4] driver_attach+0x24/0x34
> [ef82bf00] [c01a9e08] bus_add_driver+0x12c/0x1cc
> [ef82bf20] [c01aa87c] driver_register+0x6c/0x110
> [ef82bf30] [c018a770] __pci_register_driver+0x4c/0x9c
> [ef82bf50] [c03782c8] sky2_init_module+0x30/0x40
> [ef82bf60] [c0001dbc] do_one_initcall+0x34/0x1a0
> [ef82bfd0] [c0362240] do_initcalls+0x38/0x58
>
> This happens with CONFIG_SKY2=y, and "ip=on" kernel command line, so
> pci_vpd_truncate() is called before late_initcall(pci_sysfs_init),
> therefore ->attr isn't yet initialized.
>
> Acked-by: Stephen Hemminger <shemminger@vyatta.com>
> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
> Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Thanks, closed.
Rafael
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: 2.6.30-rc2-git2: Reported regressions from 2.6.29
2009-04-16 21:42 2.6.30-rc2-git2: Reported regressions from 2.6.29 Rafael J. Wysocki
2009-04-17 0:40 ` Linus Torvalds
2009-04-17 0:41 ` David Miller
@ 2009-04-17 0:46 ` Linus Torvalds
2009-04-17 21:31 ` Rafael J. Wysocki
2009-04-17 1:28 ` Jeff Chua
` (4 subsequent siblings)
7 siblings, 1 reply; 30+ messages in thread
From: Linus Torvalds @ 2009-04-17 0:46 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Linux Kernel Mailing List, Adrian Bunk, Andrew Morton,
Natalie Protasevich, Kernel Testers List, Network Development,
Linux ACPI, Linux PM List, Linux SCSI List
On Thu, 16 Apr 2009, Rafael J. Wysocki wrote:
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=13098
> Subject : 2.6.29-git12 breaks vga=0x0f07 on MSI/Intel GPU
> Submitter : Andi Kleen <andi-Vw/NltI1exuRpAAqCnN02g@public.gmane.org>
> Date : 2009-04-06 01:14 (11 days old)
> References : http://lkml.org/lkml/2009/4/5/200
> Handled-By : H. Peter Anvin <hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>
I think this got fixed already. The VGA moresettign was reverted back to
the old order.
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=13044
> Subject : 2.6.30-rc1 can't find the root fs
> Submitter : Heinz Diehl <htd-HjJ2MNWy62to6+H+lsi3Gti2O/JbrIOy@public.gmane.org>
> Date : 2009-04-08 13:35 (9 days old)
This was one of the async things that got fixed by just waiting for module
async work to finish.
Linus
^ permalink raw reply [flat|nested] 30+ messages in thread* Re: 2.6.30-rc2-git2: Reported regressions from 2.6.29
2009-04-17 0:46 ` Linus Torvalds
@ 2009-04-17 21:31 ` Rafael J. Wysocki
0 siblings, 0 replies; 30+ messages in thread
From: Rafael J. Wysocki @ 2009-04-17 21:31 UTC (permalink / raw)
To: Linus Torvalds
Cc: Linux Kernel Mailing List, Adrian Bunk, Andrew Morton,
Natalie Protasevich, Kernel Testers List, Network Development,
Linux ACPI, Linux PM List, Linux SCSI List
On Friday 17 April 2009, Linus Torvalds wrote:
>
> On Thu, 16 Apr 2009, Rafael J. Wysocki wrote:
> >
> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=13098
> > Subject : 2.6.29-git12 breaks vga=0x0f07 on MSI/Intel GPU
> > Submitter : Andi Kleen <andi@firstfloor.org>
> > Date : 2009-04-06 01:14 (11 days old)
> > References : http://lkml.org/lkml/2009/4/5/200
> > Handled-By : H. Peter Anvin <hpa@zytor.com>
>
> I think this got fixed already. The VGA moresettign was reverted back to
> the old order.
Closed.
> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=13044
> > Subject : 2.6.30-rc1 can't find the root fs
> > Submitter : Heinz Diehl <htd@fancy-poultry.org>
> > Date : 2009-04-08 13:35 (9 days old)
>
> This was one of the async things that got fixed by just waiting for module
> async work to finish.
Closed.
Thanks,
Rafael
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: 2.6.30-rc2-git2: Reported regressions from 2.6.29
2009-04-16 21:42 2.6.30-rc2-git2: Reported regressions from 2.6.29 Rafael J. Wysocki
` (2 preceding siblings ...)
2009-04-17 0:46 ` Linus Torvalds
@ 2009-04-17 1:28 ` Jeff Chua
2009-04-17 1:30 ` Zhang Rui
` (3 subsequent siblings)
7 siblings, 0 replies; 30+ messages in thread
From: Jeff Chua @ 2009-04-17 1:28 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Linux Kernel Mailing List, Adrian Bunk, Andrew Morton,
Linus Torvalds, Natalie Protasevich, Kernel Testers List,
Network Development, Linux ACPI, Linux PM List, Linux SCSI List
On Fri, Apr 17, 2009 at 5:42 AM, Rafael J. Wysocki <rjw-KKrjLPT3xs0@public.gmane.org> wrote:
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=13118
> Subject : iptables very slow after commit 784544739a25c30637397ace5489eeb6e15d7d49
> Submitter : Jeff Chua <jeff.chua.linux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Date : 2009-04-10 16:05 (7 days old)
> References : http://lkml.org/lkml/2009/4/10/111
> Handled-By : Eric Dumazet <dada1-fPLkHRcR87vqlBn2x/YWAg@public.gmane.org>
Several iterations of patches in progress. See
[PATCH] netfilter: per-cpu spin-lock with recursion (v0.8)
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=13066
> Subject : Intel HD Audio oops
> Submitter : Jeff Chua <jeff.chua.linux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Date : 2009-04-01 8:28 (16 days old)
> References : http://marc.info/?l=linux-kernel&m=123857454625829&w=4
Fixed as of April 09 2009 git pull.
Thanks,
Jeff
^ permalink raw reply [flat|nested] 30+ messages in thread* Re: 2.6.30-rc2-git2: Reported regressions from 2.6.29
2009-04-16 21:42 2.6.30-rc2-git2: Reported regressions from 2.6.29 Rafael J. Wysocki
` (3 preceding siblings ...)
2009-04-17 1:28 ` Jeff Chua
@ 2009-04-17 1:30 ` Zhang Rui
2009-04-17 2:34 ` yakui_zhao
2009-04-17 21:35 ` Rafael J. Wysocki
2009-04-17 1:37 ` Ming Lei
` (2 subsequent siblings)
7 siblings, 2 replies; 30+ messages in thread
From: Zhang Rui @ 2009-04-17 1:30 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Linux Kernel Mailing List, Adrian Bunk, Andrew Morton,
Linus Torvalds, Natalie Protasevich, Kernel Testers List,
Network Development, Linux ACPI, Linux PM List, Linux SCSI List
On Fri, 2009-04-17 at 05:42 +0800, Rafael J. Wysocki wrote:
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=13095
> Subject : thinkpad-acpi: cannot control brightness with hotkeys
> Submitter : Niel Lambrechts <niel.lambrechts@gmail.com>
> Date : 2009-04-11 23:07 (6 days old)
> References : http://lkml.org/lkml/2009/4/11/160
> Handled-By : Matthew Garrett <mjg59@srcf.ucam.org>
> Patch : http://lkml.org/lkml/2009/4/15/339
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=13048
> Subject : /sys/class/backlight/acpi_video0/* is gone on vaio laptop with Intel GM45.
> Submitter : Rodrigo L. Batista <rodrigo@gus-mg.org>
> Date : 2009-04-09 04:57 (8 days old)
> Handled-By : yakui_zhao <yakui.zhao@intel.com>
> Patch : http://bugzilla.kernel.org/attachment.cgi?id=20967
> http://bugzilla.kernel.org/attachment.cgi?id=20959
>
>
bug 13095 is a duplicate of bug 13048.
patches from Matthew and Yakui are for the same issue.
Yakui, could you verify which patch should be taken please?
thanks,
rui
^ permalink raw reply [flat|nested] 30+ messages in thread* Re: 2.6.30-rc2-git2: Reported regressions from 2.6.29
2009-04-17 1:30 ` Zhang Rui
@ 2009-04-17 2:34 ` yakui_zhao
2009-04-17 21:35 ` Rafael J. Wysocki
1 sibling, 0 replies; 30+ messages in thread
From: yakui_zhao @ 2009-04-17 2:34 UTC (permalink / raw)
To: Zhang Rui, mjq59-1xO5oi07KQx4cg9Nei1l7Q
Cc: Rafael J. Wysocki, Linux Kernel Mailing List, Adrian Bunk,
Andrew Morton, Linus Torvalds, Natalie Protasevich,
Kernel Testers List, Network Development, Linux ACPI,
Linux PM List, Linux SCSI List
On Fri, 2009-04-17 at 09:30 +0800, Zhang Rui wrote:
> On Fri, 2009-04-17 at 05:42 +0800, Rafael J. Wysocki wrote:
> >
> >
> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=13095
> > Subject : thinkpad-acpi: cannot control brightness with hotkeys
> > Submitter : Niel Lambrechts <niel.lambrechts-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> > Date : 2009-04-11 23:07 (6 days old)
> > References : http://lkml.org/lkml/2009/4/11/160
> > Handled-By : Matthew Garrett <mjg59-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org>
> > Patch : http://lkml.org/lkml/2009/4/15/339
> >
> >
> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=13048
> > Subject : /sys/class/backlight/acpi_video0/* is gone on vaio laptop with Intel GM45.
> > Submitter : Rodrigo L. Batista <rodrigo-1dof46nAmC8dnm+yROfE0A@public.gmane.org>
> > Date : 2009-04-09 04:57 (8 days old)
> > Handled-By : yakui_zhao <yakui.zhao-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> > Patch : http://bugzilla.kernel.org/attachment.cgi?id=20967
> > http://bugzilla.kernel.org/attachment.cgi?id=20959
> >
> >
> bug 13095 is a duplicate of bug 13048.
> patches from Matthew and Yakui are for the same issue.
>
> Yakui, could you verify which patch should be taken please?
The patch from Matthew is better.
It still can work even when the KMS is disabled by adding the boot
option of "i915.modeset=0".
Hi, Matthew
Will you please push the patch?
thanks.
>
> thanks,
> rui
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 30+ messages in thread* Re: 2.6.30-rc2-git2: Reported regressions from 2.6.29
2009-04-17 1:30 ` Zhang Rui
2009-04-17 2:34 ` yakui_zhao
@ 2009-04-17 21:35 ` Rafael J. Wysocki
1 sibling, 0 replies; 30+ messages in thread
From: Rafael J. Wysocki @ 2009-04-17 21:35 UTC (permalink / raw)
To: Zhang Rui
Cc: Linux Kernel Mailing List, Adrian Bunk, Andrew Morton,
Linus Torvalds, Natalie Protasevich, Kernel Testers List,
Network Development, Linux ACPI, Linux PM List, Linux SCSI List
On Friday 17 April 2009, Zhang Rui wrote:
> On Fri, 2009-04-17 at 05:42 +0800, Rafael J. Wysocki wrote:
> >
> >
> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=13095
> > Subject : thinkpad-acpi: cannot control brightness with hotkeys
> > Submitter : Niel Lambrechts <niel.lambrechts-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> > Date : 2009-04-11 23:07 (6 days old)
> > References : http://lkml.org/lkml/2009/4/11/160
> > Handled-By : Matthew Garrett <mjg59-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org>
> > Patch : http://lkml.org/lkml/2009/4/15/339
> >
> >
> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=13048
> > Subject : /sys/class/backlight/acpi_video0/* is gone on vaio laptop with Intel GM45.
> > Submitter : Rodrigo L. Batista <rodrigo-1dof46nAmC8dnm+yROfE0A@public.gmane.org>
> > Date : 2009-04-09 04:57 (8 days old)
> > Handled-By : yakui_zhao <yakui.zhao-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> > Patch : http://bugzilla.kernel.org/attachment.cgi?id=20967
> > http://bugzilla.kernel.org/attachment.cgi?id=20959
> >
> >
> bug 13095 is a duplicate of bug 13048.
> patches from Matthew and Yakui are for the same issue.
OK, closed 13095 as a duplicate.
Thanks,
Rafael
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: 2.6.30-rc2-git2: Reported regressions from 2.6.29
2009-04-16 21:42 2.6.30-rc2-git2: Reported regressions from 2.6.29 Rafael J. Wysocki
` (4 preceding siblings ...)
2009-04-17 1:30 ` Zhang Rui
@ 2009-04-17 1:37 ` Ming Lei
2009-04-17 21:36 ` Rafael J. Wysocki
2009-04-24 13:44 ` Kalle Valo
[not found] ` <200904170752.48078.edt@aei.ca>
7 siblings, 1 reply; 30+ messages in thread
From: Ming Lei @ 2009-04-17 1:37 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Linux Kernel Mailing List, Adrian Bunk, Andrew Morton,
Linus Torvalds, Natalie Protasevich, Kernel Testers List,
Network Development, Linux ACPI, Linux PM List, Linux SCSI List,
video4linux-list, laurent.pinchart, mchehab
2009/4/17 Rafael J. Wysocki <rjw@sisk.pl>:
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=13125
> Subject : active uvcvideo breaks over suspend
> Submitter : Alan Jenkins <alan-jenkins@tuffmail.co.uk>
> Date : 2009-04-15 10:12 (2 days old)
> References : http://marc.info/?l=linux-kernel&m=123979009508840&w=4
>
It is a bug in resume path of uvcvideo driver, and I have sent a patch
to laurent.pinchart@skynet.be,
mchehab@infradead.org and video4linux-list@redhat.com to fix it, but
still no echo from them.
The patch title is V4L/DVB:usbvideo:fix uvc resume failed.
Rafael J.
If you would like to apply it ,I can resend to you. Thanks!
--
Lei Ming
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 30+ messages in thread* Re: 2.6.30-rc2-git2: Reported regressions from 2.6.29
2009-04-17 1:37 ` Ming Lei
@ 2009-04-17 21:36 ` Rafael J. Wysocki
2009-04-17 23:56 ` Laurent Pinchart
2009-04-18 2:32 ` leiming
0 siblings, 2 replies; 30+ messages in thread
From: Rafael J. Wysocki @ 2009-04-17 21:36 UTC (permalink / raw)
To: Ming Lei
Cc: Linux Kernel Mailing List, Adrian Bunk, Andrew Morton,
Linus Torvalds, Natalie Protasevich, Kernel Testers List,
Network Development, Linux ACPI, Linux PM List, Linux SCSI List,
video4linux-list, laurent.pinchart, mchehab
On Friday 17 April 2009, Ming Lei wrote:
> 2009/4/17 Rafael J. Wysocki <rjw@sisk.pl>:
> >
> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=13125
> > Subject : active uvcvideo breaks over suspend
> > Submitter : Alan Jenkins <alan-jenkins@tuffmail.co.uk>
> > Date : 2009-04-15 10:12 (2 days old)
> > References : http://marc.info/?l=linux-kernel&m=123979009508840&w=4
> >
>
> It is a bug in resume path of uvcvideo driver, and I have sent a patch
> to laurent.pinchart@skynet.be,
> mchehab@infradead.org and video4linux-list@redhat.com to fix it, but
> still no echo from them.
>
> The patch title is V4L/DVB:usbvideo:fix uvc resume failed.
>
> Rafael J.
> If you would like to apply it ,I can resend to you. Thanks!
Please resend.
Rafael
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: 2.6.30-rc2-git2: Reported regressions from 2.6.29
2009-04-17 21:36 ` Rafael J. Wysocki
@ 2009-04-17 23:56 ` Laurent Pinchart
[not found] ` <200904180156.24366.laurent.pinchart-AgBVmzD5pcezQB+pC5nmwQ@public.gmane.org>
2009-04-18 2:32 ` leiming
1 sibling, 1 reply; 30+ messages in thread
From: Laurent Pinchart @ 2009-04-17 23:56 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Ming Lei, Linux Kernel Mailing List, Adrian Bunk, Andrew Morton,
Linus Torvalds, Natalie Protasevich, Kernel Testers List,
Network Development, Linux ACPI, Linux PM List, Linux SCSI List,
video4linux-list, mchehab
Hi,
On Friday 17 April 2009 23:36:11 Rafael J. Wysocki wrote:
> On Friday 17 April 2009, Ming Lei wrote:
> > 2009/4/17 Rafael J. Wysocki <rjw@sisk.pl>:
> > > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=13125
> > > Subject : active uvcvideo breaks over suspend
> > > Submitter : Alan Jenkins <alan-jenkins@tuffmail.co.uk>
> > > Date : 2009-04-15 10:12 (2 days old)
> > > References :
> > > http://marc.info/?l=linux-kernel&m=123979009508840&w=4
> >
> > It is a bug in resume path of uvcvideo driver, and I have sent a patch
> > to laurent.pinchart@skynet.be,
> > mchehab@infradead.org and video4linux-list@redhat.com to fix it, but
> > still no echo from them.
> >
> > The patch title is V4L/DVB:usbvideo:fix uvc resume failed.
> >
> > Rafael J.
> > If you would like to apply it ,I can resend to you. Thanks!
>
> Please resend.
I'm reviewing the patch and I'll push it through my tree during the weekend.
Sorry for the delay, I'm currently traveling.
Best regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 30+ messages in thread* Re: 2.6.30-rc2-git2: Reported regressions from 2.6.29
2009-04-17 21:36 ` Rafael J. Wysocki
2009-04-17 23:56 ` Laurent Pinchart
@ 2009-04-18 2:32 ` leiming
2009-04-18 2:55 ` Linus Torvalds
1 sibling, 1 reply; 30+ messages in thread
From: leiming @ 2009-04-18 2:32 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Linux Kernel Mailing List, Adrian Bunk, Andrew Morton,
Linus Torvalds, Natalie Protasevich, Kernel Testers List,
Network Development, Linux ACPI, Linux PM List, Linux SCSI List,
video4linux-list, laurent.pinchart, mchehab
于 Fri, 17 Apr 2009 23:36:11 +0200
"Rafael J. Wysocki" <rjw@sisk.pl> 写道:
> On Friday 17 April 2009, Ming Lei wrote:
> > 2009/4/17 Rafael J. Wysocki <rjw@sisk.pl>:
> > >
> > > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=13125
> > > Subject : active uvcvideo breaks over suspend
> > > Submitter : Alan Jenkins <alan-jenkins@tuffmail.co.uk>
> > > Date : 2009-04-15 10:12 (2 days old)
> > > References :
> > > http://marc.info/?l=linux-kernel&m=123979009508840&w=4
> > >
> >
> > It is a bug in resume path of uvcvideo driver, and I have sent a
> > patch to laurent.pinchart@skynet.be,
> > mchehab@infradead.org and video4linux-list@redhat.com to fix it,
> > but still no echo from them.
> >
> > The patch title is V4L/DVB:usbvideo:fix uvc resume failed.
> >
> > Rafael J.
> > If you would like to apply it ,I can resend to you. Thanks!
>
> Please resend.
>
> Rafael
From 5715e310a939f3f7cd3e88eae8f25fedbb28def4 Mon Sep 17 00:00:00 2001
From: Ming Lei <tom.leiming@gmail.com>
Date: Wed, 15 Apr 2009 22:32:51 +0800
Subject: [PATCH] V4L/DVB:usbvideo:fix uvc resume failed
Now urb buffers is not freed before suspend, so uvc_alloc_urb_buffers
should return packet counts allocated originally during uvc resume
, instead of zero.
This patch is against v2.6.30-rc2.
Signed-off-by: Ming Lei <tom.leiming@gmail.com>
---
drivers/media/video/uvc/uvc_video.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/media/video/uvc/uvc_video.c b/drivers/media/video/uvc/uvc_video.c
index a95e173..c050b22 100644
--- a/drivers/media/video/uvc/uvc_video.c
+++ b/drivers/media/video/uvc/uvc_video.c
@@ -742,7 +742,7 @@ static int uvc_alloc_urb_buffers(struct uvc_video_device *video,
/* Buffers are already allocated, bail out. */
if (video->urb_size)
- return 0;
+ return DIV_ROUND_UP(video->urb_size, psize);
/* Compute the number of packets. Bulk endpoints might transfer UVC
* payloads accross multiple URBs.
--
1.6.0.GIT
--
Lei Ming
^ permalink raw reply related [flat|nested] 30+ messages in thread
* Re: 2.6.30-rc2-git2: Reported regressions from 2.6.29
2009-04-18 2:32 ` leiming
@ 2009-04-18 2:55 ` Linus Torvalds
2009-04-18 3:50 ` leiming
2009-04-18 4:51 ` leiming
0 siblings, 2 replies; 30+ messages in thread
From: Linus Torvalds @ 2009-04-18 2:55 UTC (permalink / raw)
To: leiming
Cc: Rafael J. Wysocki, Linux Kernel Mailing List, Adrian Bunk,
Andrew Morton, Natalie Protasevich, Kernel Testers List,
Network Development, Linux ACPI, Linux PM List, Linux SCSI List,
video4linux-list-H+wXaHxf7aLQT0dZR+AlfA,
laurent.pinchart-AgBVmzD5pcezQB+pC5nmwQ,
mchehab-wEGCiKHe2LqWVfeAwA7xHQ
On Sat, 18 Apr 2009, leiming wrote:
>
> >From 5715e310a939f3f7cd3e88eae8f25fedbb28def4 Mon Sep 17 00:00:00 2001
> From: Ming Lei <tom.leiming-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Date: Wed, 15 Apr 2009 22:32:51 +0800
> Subject: [PATCH] V4L/DVB:usbvideo:fix uvc resume failed
>
> Now urb buffers is not freed before suspend, so uvc_alloc_urb_buffers
> should return packet counts allocated originally during uvc resume
> , instead of zero.
>
> This patch is against v2.6.30-rc2.
>
> Signed-off-by: Ming Lei <tom.leiming-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
> drivers/media/video/uvc/uvc_video.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/media/video/uvc/uvc_video.c b/drivers/media/video/uvc/uvc_video.c
> index a95e173..c050b22 100644
> --- a/drivers/media/video/uvc/uvc_video.c
> +++ b/drivers/media/video/uvc/uvc_video.c
> @@ -742,7 +742,7 @@ static int uvc_alloc_urb_buffers(struct uvc_video_device *video,
>
> /* Buffers are already allocated, bail out. */
> if (video->urb_size)
> - return 0;
> + return DIV_ROUND_UP(video->urb_size, psize);
I don't think this is right. It should round _down_.
It's supposed to return 'npackets', but if you pass it a different packet
size than it was passed originally, it can now return a potentially bigger
number than the already allocated buffer, no?
So I think it should round down (ie use a regular divide). No?
Linuse
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: 2.6.30-rc2-git2: Reported regressions from 2.6.29
2009-04-18 2:55 ` Linus Torvalds
@ 2009-04-18 3:50 ` leiming
2009-04-18 4:51 ` leiming
1 sibling, 0 replies; 30+ messages in thread
From: leiming @ 2009-04-18 3:50 UTC (permalink / raw)
To: Linus Torvalds
Cc: Rafael J. Wysocki, Linux Kernel Mailing List, Adrian Bunk,
Andrew Morton, Natalie Protasevich, Kernel Testers List,
Network Development, Linux ACPI, Linux PM List, Linux SCSI List,
video4linux-list, laurent.pinchart, mchehab
On Fri, 17 Apr 2009 19:55:29 -0700 (PDT)
Linus Torvalds <torvalds@linux-foundation.org> wrote:
> @@ -742,7 +742,7 @@ static int uvc_alloc_urb_buffers(struct
> > uvc_video_device *video,
> > /* Buffers are already allocated, bail out. */
> > if (video->urb_size)
> > - return 0;
> > + return DIV_ROUND_UP(video->urb_size, psize);
>
> I don't think this is right. It should round _down_.
>
> It's supposed to return 'npackets', but if you pass it a different
> packet size than it was passed originally, it can now return a
Now uvc only uses the previous allocated buffer in suspend/resume
path, so the packet size doen't change in this path.
> potentially bigger number than the already allocated buffer, no?
If this case does exist, the URBs need to be updated and the patch is
not enough.
>
> So I think it should round down (ie use a regular divide). No?
Because the following fact:
uvc_alloc_urb_buffers()
{
...
video->urb_size = psize * npackets;
...
}
so DIV_ROUND_UP still can work correctly.
Thanks!
--
Lei Ming
^ permalink raw reply [flat|nested] 30+ messages in thread* Re: 2.6.30-rc2-git2: Reported regressions from 2.6.29
2009-04-18 2:55 ` Linus Torvalds
2009-04-18 3:50 ` leiming
@ 2009-04-18 4:51 ` leiming
2009-04-18 12:33 ` Rafael J. Wysocki
2009-04-20 20:08 ` Laurent Pinchart
1 sibling, 2 replies; 30+ messages in thread
From: leiming @ 2009-04-18 4:51 UTC (permalink / raw)
To: Linus Torvalds
Cc: Rafael J. Wysocki, Linux Kernel Mailing List, Adrian Bunk,
Andrew Morton, Natalie Protasevich, Kernel Testers List,
Network Development, Linux ACPI, Linux PM List, Linux SCSI List,
video4linux-list, laurent.pinchart, mchehab
On Fri, 17 Apr 2009 19:55:29 -0700 (PDT)
Linus Torvalds <torvalds@linux-foundation.org> wrote:
> > @@ -742,7 +742,7 @@ static int uvc_alloc_urb_buffers(struct
> > uvc_video_device *video,
> > /* Buffers are already allocated, bail out. */
> > if (video->urb_size)
> > - return 0;
> > + return DIV_ROUND_UP(video->urb_size, psize);
>
> I don't think this is right. It should round _down_.
>
> It's supposed to return 'npackets', but if you pass it a different
> packet size than it was passed originally, it can now return a
> potentially bigger number than the already allocated buffer, no?
>
> So I think it should round down (ie use a regular divide). No?
Yes,you are correct, please ignore my last reply, and following is
the fixed patch.
Thanks.
>From a3b3d72cdd57a0699fb643b41b78eb7beb211ff5 Mon Sep 17 00:00:00 2001
From: Ming Lei <tom.leiming@gmail.com>
Date: Wed, 15 Apr 2009 22:32:51 +0800
Subject: [PATCH] V4L/DVB:usbvideo:fix uvc resume failed(v2)
Now urb buffers is not freed before suspend, so uvc_alloc_urb_buffers
should return packet counts allocated originally during uvc resume
, instead of zero.
This version uses round down to return packet counts on Linus's
suggestions, or else may lead to buffer destructed if packet size
is changed before calling uvc_alloc_urb_buffers() in this kind of
case.
This patch is against v2.6.30-rc2.
Signed-off-by: Ming Lei <tom.leiming@gmail.com>
---
drivers/media/video/uvc/uvc_video.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/media/video/uvc/uvc_video.c b/drivers/media/video/uvc/uvc_video.c
index a95e173..6ce974d 100644
--- a/drivers/media/video/uvc/uvc_video.c
+++ b/drivers/media/video/uvc/uvc_video.c
@@ -742,7 +742,7 @@ static int uvc_alloc_urb_buffers(struct uvc_video_device *video,
/* Buffers are already allocated, bail out. */
if (video->urb_size)
- return 0;
+ return video->urb_size / psize;
/* Compute the number of packets. Bulk endpoints might transfer UVC
* payloads accross multiple URBs.
--
1.6.0.GIT
--
Lei Ming
^ permalink raw reply related [flat|nested] 30+ messages in thread
* Re: 2.6.30-rc2-git2: Reported regressions from 2.6.29
2009-04-18 4:51 ` leiming
@ 2009-04-18 12:33 ` Rafael J. Wysocki
2009-04-20 20:08 ` Laurent Pinchart
1 sibling, 0 replies; 30+ messages in thread
From: Rafael J. Wysocki @ 2009-04-18 12:33 UTC (permalink / raw)
To: leiming
Cc: Linus Torvalds, Linux Kernel Mailing List, Adrian Bunk,
Andrew Morton, Natalie Protasevich, Kernel Testers List,
Network Development, Linux ACPI, Linux PM List, Linux SCSI List,
video4linux-list, laurent.pinchart, mchehab
On Saturday 18 April 2009, leiming wrote:
> On Fri, 17 Apr 2009 19:55:29 -0700 (PDT)
> Linus Torvalds <torvalds@linux-foundation.org> wrote:
>
> > > @@ -742,7 +742,7 @@ static int uvc_alloc_urb_buffers(struct
> > > uvc_video_device *video,
> > > /* Buffers are already allocated, bail out. */
> > > if (video->urb_size)
> > > - return 0;
> > > + return DIV_ROUND_UP(video->urb_size, psize);
> >
> > I don't think this is right. It should round _down_.
> >
> > It's supposed to return 'npackets', but if you pass it a different
> > packet size than it was passed originally, it can now return a
> > potentially bigger number than the already allocated buffer, no?
> >
> > So I think it should round down (ie use a regular divide). No?
>
> Yes,you are correct, please ignore my last reply, and following is
> the fixed patch.
>
> Thanks.
Thanks for the patch, I've updated the bug entry to point to it.
Best,
Rafael
> From a3b3d72cdd57a0699fb643b41b78eb7beb211ff5 Mon Sep 17 00:00:00 2001
> From: Ming Lei <tom.leiming@gmail.com>
> Date: Wed, 15 Apr 2009 22:32:51 +0800
> Subject: [PATCH] V4L/DVB:usbvideo:fix uvc resume failed(v2)
>
> Now urb buffers is not freed before suspend, so uvc_alloc_urb_buffers
> should return packet counts allocated originally during uvc resume
> , instead of zero.
>
> This version uses round down to return packet counts on Linus's
> suggestions, or else may lead to buffer destructed if packet size
> is changed before calling uvc_alloc_urb_buffers() in this kind of
> case.
>
> This patch is against v2.6.30-rc2.
>
> Signed-off-by: Ming Lei <tom.leiming@gmail.com>
> ---
> drivers/media/video/uvc/uvc_video.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/media/video/uvc/uvc_video.c b/drivers/media/video/uvc/uvc_video.c
> index a95e173..6ce974d 100644
> --- a/drivers/media/video/uvc/uvc_video.c
> +++ b/drivers/media/video/uvc/uvc_video.c
> @@ -742,7 +742,7 @@ static int uvc_alloc_urb_buffers(struct uvc_video_device *video,
>
> /* Buffers are already allocated, bail out. */
> if (video->urb_size)
> - return 0;
> + return video->urb_size / psize;
>
> /* Compute the number of packets. Bulk endpoints might transfer UVC
> * payloads accross multiple URBs.
> --
> 1.6.0.GIT
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: 2.6.30-rc2-git2: Reported regressions from 2.6.29
2009-04-18 4:51 ` leiming
2009-04-18 12:33 ` Rafael J. Wysocki
@ 2009-04-20 20:08 ` Laurent Pinchart
[not found] ` <200904202208.23899.laurent.pinchart-AgBVmzD5pcezQB+pC5nmwQ@public.gmane.org>
1 sibling, 1 reply; 30+ messages in thread
From: Laurent Pinchart @ 2009-04-20 20:08 UTC (permalink / raw)
To: leiming
Cc: Linus Torvalds, Rafael J. Wysocki, Linux Kernel Mailing List,
Adrian Bunk, Andrew Morton, Natalie Protasevich,
Kernel Testers List, Network Development, Linux ACPI,
Linux PM List, Linux SCSI List, video4linux-list, mchehab
On Saturday 18 April 2009 06:51:11 leiming wrote:
> On Fri, 17 Apr 2009 19:55:29 -0700 (PDT)
>
> Linus Torvalds <torvalds@linux-foundation.org> wrote:
> > > @@ -742,7 +742,7 @@ static int uvc_alloc_urb_buffers(struct
> > > uvc_video_device *video,
> > > /* Buffers are already allocated, bail out. */
> > > if (video->urb_size)
> > > - return 0;
> > > + return DIV_ROUND_UP(video->urb_size, psize);
> >
> > I don't think this is right. It should round _down_.
> >
> > It's supposed to return 'npackets', but if you pass it a different
> > packet size than it was passed originally, it can now return a
> > potentially bigger number than the already allocated buffer, no?
> >
> > So I think it should round down (ie use a regular divide). No?
>
> Yes,you are correct, please ignore my last reply, and following is
> the fixed patch.
psize and video->urb_size shouldn't have changed before and after resume,
otherwise we'll get into trouble anyway. A regular divide and a round-up
divide should then return the same result. I'll take the regular divide, as it
will be more efficient.
> Thanks.
>
> From a3b3d72cdd57a0699fb643b41b78eb7beb211ff5 Mon Sep 17 00:00:00 2001
> From: Ming Lei <tom.leiming@gmail.com>
> Date: Wed, 15 Apr 2009 22:32:51 +0800
> Subject: [PATCH] V4L/DVB:usbvideo:fix uvc resume failed(v2)
>
> Now urb buffers is not freed before suspend, so uvc_alloc_urb_buffers
> should return packet counts allocated originally during uvc resume
> , instead of zero.
>
> This version uses round down to return packet counts on Linus's
> suggestions, or else may lead to buffer destructed if packet size
> is changed before calling uvc_alloc_urb_buffers() in this kind of
> case.
The comment is misleading. If the packet size changes we need to reallocate
the buffers anyway. Have you checked if the packet size (which depends on the
endpoint being selected) can be changed between suspend and resume, either by
the uvcvideo driver (I don't think it can) or the USB core ?
Best regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: 2.6.30-rc2-git2: Reported regressions from 2.6.29
2009-04-16 21:42 2.6.30-rc2-git2: Reported regressions from 2.6.29 Rafael J. Wysocki
` (5 preceding siblings ...)
2009-04-17 1:37 ` Ming Lei
@ 2009-04-24 13:44 ` Kalle Valo
[not found] ` <87ljpqqi89.fsf-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
[not found] ` <200904170752.48078.edt@aei.ca>
7 siblings, 1 reply; 30+ messages in thread
From: Kalle Valo @ 2009-04-24 13:44 UTC (permalink / raw)
To: ext Rafael J. Wysocki
Cc: Linux Kernel Mailing List, Adrian Bunk, Andrew Morton,
Linus Torvalds, Natalie Protasevich, Kernel Testers List,
Network Development, Linux ACPI, Linux PM List, Linux SCSI List
"Rafael J. Wysocki" <rjw@sisk.pl> writes:
> This message contains a list of some regressions from 2.6.29, for
> which there are no fixes in the mainline I know of. If any of them
> have been fixed already, please let me know.
>
> If you know of any other unresolved regressions from 2.6.29, please
> let me know either and I'll add them to the list. Also, please let
> me know if any of the entries below are invalid.
>
> Each entry from the list will be sent additionally in an automatic reply to
> this message with CCs to the people involved in reporting and handling the
> issue.
>
[...]
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=13067
> Subject : iwl3945: wlan0: beacon loss from AP - sending probe request
> Submitter : Maciej Rutecki <maciej.rutecki@gmail.com>
> Date : 2009-04-05 9:11 (12 days old)
> References : http://marc.info/?l=linux-kernel&m=123892272218266&w=4
The regression here is that I added a printk() to inform about beacon
loss. The issue has been there a long time, the printk() just exposed
it.
Michael wrote a patch which silences the printk:
http://git.kernel.org/?p=linux/kernel/git/linville/wireless-testing.git;a=commit;h=16eaea5faa37d552b14e246ca56a436e55ca67b3
I fixed the beacon loss detection here:
http://git.kernel.org/?p=linux/kernel/git/linville/wireless-testing.git;a=commit;h=3b6dc5a431e4fef35717cba53544a95209f49b68
John, I think Michael's patch should be sent to 2.6.30. Any chances
for that?
Rafael, is it possible to send your regression mails to
linux-wireless@vger.kernel.org as well? Very few wireless developers
have time to follow netdev or lkml.
--
Kalle Valo
^ permalink raw reply [flat|nested] 30+ messages in thread[parent not found: <200904170752.48078.edt@aei.ca>]